log more when invoking region replacement start saga

oxidecomputer · Aug 13, 2024 · 4a0ae26 · 4a0ae26
1 parent fea9ad9
commit 4a0ae26
Showing 1 changed file with 21 additions and 6 deletions.
diff --git a/nexus/src/app/background/tasks/region_snapshot_replacement_start.rs b/nexus/src/app/background/tasks/region_snapshot_replacement_start.rs
@@ -185,25 +185,40 @@ impl RegionSnapshotReplacementDetector {
             let result = self
                 .send_start_request(
                     authn::saga::Serialized::for_opctx(opctx),
-                    request,
+                    request.clone(),
                 )
                 .await;
 
             match result {
                 Ok(()) => {
-                    let s = format!("start invoked ok for {request_id}");
+                    let s = format!(
+                        "region snapshot replacement start invoked ok for \
+                        {request_id}"
+                    );
 
-                    info!(&log, "{s}");
+                    info!(
+                        &log,
+                        "{s}";
+                        "request.snapshot_id" => %request.old_snapshot_id,
+                        "request.region_id" => %request.old_region_id,
+                        "request.dataset_id" => %request.old_dataset_id,
+                    );
                     status.start_invoked_ok.push(s);
                 }
 
                 Err(e) => {
                     let s = format!(
-                        "sending region snapshot replacement request failed: \
-                        {e}",
+                        "invoking region snapshot replacement start for \
+                        {request_id} failed: {e}",
                     );
 
-                    error!(&log, "{s}");
+                    error!(
+                        &log,
+                        "{s}";
+                        "request.snapshot_id" => %request.old_snapshot_id,
+                        "request.region_id" => %request.old_region_id,
+                        "request.dataset_id" => %request.old_dataset_id,
+                    );
                     status.errors.push(s);
                 }
             }