Skip to content

Commit

Permalink
more comments always
Browse files Browse the repository at this point in the history
  • Loading branch information
jmpesp committed Aug 16, 2024
1 parent 9a9cc60 commit 43f1d71
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions nexus/src/app/background/tasks/region_snapshot_replacement_step.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,18 @@ impl RegionSnapshotReplacementFindAffected {
}
}

// Any request in state Running means that the target replacement has
// occurred already, meaning the region snapshot being replaced is not
// present as a target in the snapshot's volume construction request
// anymore. Any future usage of that snapshot (as a source for a disk or
// otherwise) will get a volume construction request that references the
// replacement read-only region.
//
// "step" records are created here for each volume found that still
// references the replaced region snapshot, most likely having been created
// by copying the snapshot's volume construction request before the target
// replacement occurred. These volumes also need to have target replacement
// performed, and this is captured in this "step" record.
async fn create_step_records_for_affected_volumes(
&self,
opctx: &OpContext,
Expand Down

0 comments on commit 43f1d71

Please sign in to comment.