Skip to content

Commit

Permalink
sled-agent-client doesn't depend on sled-storage (#4829)
Browse files Browse the repository at this point in the history
If someone is incrementally working on sled-storage, poking at something
fully unrelated to the API, they’ll need to rebuild all of Nexus. Why?

We have the following dependencies:
- Nexus depends on sled_agent_client
- sled_agent_client depends on sled_storage
… so if you poke at sled_storage, you gotta rebuild Nexus.

This PR removes that (not actually needed) dependency -- now, updates to
sled-storage do not cause Nexus to rebuild
  • Loading branch information
smklein authored Jan 17, 2024
1 parent 5c7ac9a commit 213d5cc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion clients/sled-agent-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ reqwest = { workspace = true, features = [ "json", "rustls-tls", "stream" ] }
schemars.workspace = true
serde.workspace = true
slog.workspace = true
sled-storage.workspace = true
uuid.workspace = true
omicron-workspace-hack.workspace = true

0 comments on commit 213d5cc

Please sign in to comment.