Skip to content

Commit

Permalink
one replacement request goes one way, one goes the other way, so what
Browse files Browse the repository at this point in the history
  • Loading branch information
jmpesp committed Jun 26, 2024
1 parent 68846ca commit 0bd3f35
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion nexus/src/app/sagas/region_replacement_drive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,12 @@ async fn check_from_previous_propolis_step(
// If this saga does not wait, it will interleave with the instance
// migration saga. Depending on Nexus' view of what stage the migration is
// in, volume replacement requests could be sent to the source propolis or
// destination propolis.
// destination propolis. This is because any call to
// `instance_fetch_with_vmm` will always return a VMM that is either a
// migration source or not migrating. If this saga calls
// `instance_fetch_with_vmm` multiple times during a migration, it will
// return the source propolis until the migration is done, where then it
// will return the destination propolis.
//
// Processing a replacement request does _not_ cause an activation, so
// sending a replacement request to the source propolis will not cause the
Expand Down

0 comments on commit 0bd3f35

Please sign in to comment.