Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions under which we restart a client IO task are somewhat baroque:
This PR adds more specific types:
enum ClientNegotiationFailed
andenum ClientFaultReason
. Mid-negotiation restarts must provide aClientNegotiationFailed
; faulting the IO task must provide aClientFaultReason
. Both of these types are then converted into aClientStopReason
for logging.In addition, faulting a client is now done through
Downstairs::fault_client
instead of calling bothDownstairs::skip_all_jobs
andDownstairsClient::fault
. Having a single function makes this harder to mess up!