-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polling on instance list #2391
Merged
Merged
Polling on instance list #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
poll-instance-list
branch
from
August 23, 2024 13:26
7dbe8c6
to
3d165d0
Compare
david-crespo
force-pushed
the
poll-instance-list
branch
from
August 23, 2024 13:28
3d165d0
to
57173bc
Compare
…ances transitioning
charliepark
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 23, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2377
Demo
When the page loads below, it polls every 3 seconds because there is an instance in a starting state. After 30 seconds, it would switch to polling every minute, but I don't wait for that in this clip. I stop the instance, which causes it to transition to
stopping
, and thestopped
(because of the polling). At that point, there are no instances in transitional states, so polling slows to every minute (i.e., not at all in the short time in this clip). Then when I start the instance it polls again while it's instarting
and then stops (slows) again after it'srunning
.2024-08-23-instance-list-polling.mp4