/lookup/instances/:id looks up instance and redirects to project instance route
#1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
instance-by-id
branch
from
6c5ac66 to
b1a6317
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 481 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 428 | 1 | 52 | 0 |
Click to see the invalid file list
- app/pages/lookups.ts
david-crespo
force-pushed
the
instance-by-id
branch
from
b1a6317 to
2f6a353
Compare
david-crespo
force-pushed
the
instance-by-id
branch
from
2f6a353 to
3d6e233
Compare
david-crespo
force-pushed
the
instance-by-id
branch
from
3d6e233 to
717e944
Compare
david-crespo
force-pushed
the
instance-by-id
branch
from
717e944 to
17149ab
Compare
david-crespo
changed the title
/instances/:id looks up instance and redirects to project instance route/lookup/instances/:id looks up instance and redirects to project instance route
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 14, 2024
Needed to make oxidecomputer/console#1944 work. Adding one top-level route `/lookup/*` so we can freely add more routes under it in the console without adding anything here. Will hold on merging until after the release is finalized.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 23, 2024
oxidecomputer/console@e5a1f80...80f1167 * [80f11673](oxidecomputer/console@80f11673) oxidecomputer/console#1957 * [5d989a70](oxidecomputer/console@5d989a70) oxidecomputer/console#1959 * [d4ec1927](oxidecomputer/console@d4ec1927) turn off license-eye comments, I hate them. CI failure is sufficient * [f8d2f36e](oxidecomputer/console@f8d2f36e) oxidecomputer/console#1960 * [e0b676dc](oxidecomputer/console@e0b676dc) upgrade husky commands for v9 https://github.com/typicode/husky/releases/tag/v9.0.1 * [f31d5331](oxidecomputer/console@f31d5331) oxidecomputer/console#1944 * [b4552eea](oxidecomputer/console@b4552eea) Revert "Revert all app changes since v6 except two small fixes (oxidecomputer/console#1958)" * [1f8ebf28](oxidecomputer/console@1f8ebf28) oxidecomputer/console#1958 * [b454cefd](oxidecomputer/console@b454cefd) oxidecomputer/console#1955 * [1ce32d32](oxidecomputer/console@1ce32d32) oxidecomputer/console#1956 * [794ae11d](oxidecomputer/console@794ae11d) oxidecomputer/console#1952 * [903b8f6a](oxidecomputer/console@903b8f6a) tweak api-diff: fix type error on first arg, use dax's new built-in pipe * [a4e15cdd](oxidecomputer/console@a4e15cdd) oxidecomputer/console#1950 * [32037d40](oxidecomputer/console@32037d40) oxidecomputer/console#1949 * [f02678b0](oxidecomputer/console@f02678b0) vite 5.1 * [1936e0d8](oxidecomputer/console@1936e0d8) oxidecomputer/console#1948 * [cfda1636](oxidecomputer/console@cfda1636) forgot to bump mockServiceWorker.js (no actual changes) * [4792105e](oxidecomputer/console@4792105e) oxidecomputer/console#1943 * [a26db9ea](oxidecomputer/console@a26db9ea) upgrade date-fns thru major version, update calls accordingly * [3dd635a6](oxidecomputer/console@3dd635a6) oxidecomputer/console#1933 * [6c8f7a9c](oxidecomputer/console@6c8f7a9c) upgrade filesize through a major version * [8f641b97](oxidecomputer/console@8f641b97) remove blathering in readme about node 16, which is EOL * [e9d157a1](oxidecomputer/console@e9d157a1) do ladle too—oh my god why does it have 3000 lines in the lockfile * [e1cdcc13](oxidecomputer/console@e1cdcc13) oxidecomputer/console#1941 * [76877ffb](oxidecomputer/console@76877ffb) oxidecomputer/console#1938
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 26, 2024
### User-facing changes * [80f11673](oxidecomputer/console@80f11673) oxidecomputer/console#1957 * [f31d5331](oxidecomputer/console@f31d5331) oxidecomputer/console#1944 * [b454cefd](oxidecomputer/console@b454cefd) oxidecomputer/console#1955 * [1936e0d8](oxidecomputer/console@1936e0d8) oxidecomputer/console#1948 --- ### All changes oxidecomputer/console@e5a1f80...80f1167 * [80f11673](oxidecomputer/console@80f11673) oxidecomputer/console#1957 * [5d989a70](oxidecomputer/console@5d989a70) oxidecomputer/console#1959 * [d4ec1927](oxidecomputer/console@d4ec1927) turn off license-eye comments, I hate them. CI failure is sufficient * [f8d2f36e](oxidecomputer/console@f8d2f36e) oxidecomputer/console#1960 * [e0b676dc](oxidecomputer/console@e0b676dc) upgrade husky commands for v9 https://github.com/typicode/husky/releases/tag/v9.0.1 * [f31d5331](oxidecomputer/console@f31d5331) oxidecomputer/console#1944 * [b4552eea](oxidecomputer/console@b4552eea) Revert "Revert all app changes since v6 except two small fixes (oxidecomputer/console#1958)" * [1f8ebf28](oxidecomputer/console@1f8ebf28) oxidecomputer/console#1958 * [b454cefd](oxidecomputer/console@b454cefd) oxidecomputer/console#1955 * [1ce32d32](oxidecomputer/console@1ce32d32) oxidecomputer/console#1956 * [794ae11d](oxidecomputer/console@794ae11d) oxidecomputer/console#1952 * [903b8f6a](oxidecomputer/console@903b8f6a) tweak api-diff: fix type error on first arg, use dax's new built-in pipe * [a4e15cdd](oxidecomputer/console@a4e15cdd) oxidecomputer/console#1950 * [32037d40](oxidecomputer/console@32037d40) oxidecomputer/console#1949 * [f02678b0](oxidecomputer/console@f02678b0) vite 5.1 * [1936e0d8](oxidecomputer/console@1936e0d8) oxidecomputer/console#1948 * [cfda1636](oxidecomputer/console@cfda1636) forgot to bump mockServiceWorker.js (no actual changes) * [4792105e](oxidecomputer/console@4792105e) oxidecomputer/console#1943 * [a26db9ea](oxidecomputer/console@a26db9ea) upgrade date-fns thru major version, update calls accordingly * [3dd635a6](oxidecomputer/console@3dd635a6) oxidecomputer/console#1933 * [6c8f7a9c](oxidecomputer/console@6c8f7a9c) upgrade filesize through a major version * [8f641b97](oxidecomputer/console@8f641b97) remove blathering in readme about node 16, which is EOL * [e9d157a1](oxidecomputer/console@e9d157a1) do ladle too—oh my god why does it have 3000 lines in the lockfile * [e1cdcc13](oxidecomputer/console@e1cdcc13) oxidecomputer/console#1941 * [76877ffb](oxidecomputer/console@76877ffb) oxidecomputer/console#1938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sneaky idea from @augustuswm, mostly for him to use. Depends on oxidecomputer/omicron#5040, which adds
/lookup/*as a route in Nexus.2024-02-07-instance-id-route.mp4