Skip to content

Commit

Permalink
Try macos-14 runner for playwright tests (#1943)
Browse files Browse the repository at this point in the history
* try macos-14 runner for playwright tests

* bust npm cache

* missed a node-version
  • Loading branch information
david-crespo authored Feb 8, 2024
1 parent a26db9e commit 4792105
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 27 deletions.
30 changes: 12 additions & 18 deletions .github/workflows/lintBuildTest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ on:
jobs:
install:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: macos-14
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
- name: Cache node_modules
uses: actions/cache@v3
Expand All @@ -26,16 +26,13 @@ jobs:
run: npm install
ci:
timeout-minutes: 5
runs-on: ubuntu-latest
runs-on: macos-14
needs: install
steps:
# This repo is unstable and unnecessary: https://github.com/microsoft/linux-package-repositories/issues/34
- name: Disable packages.microsoft.com repo
run: sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
- name: Get node_modules from cache
uses: actions/cache@v3
Expand All @@ -54,20 +51,17 @@ jobs:
playwright:
name: Playwright (${{ matrix.browser }})
timeout-minutes: 20
runs-on: ubuntu-latest
runs-on: macos-14
needs: install
strategy:
fail-fast: false
matrix:
browser: ['chrome', 'firefox', 'safari']
steps:
# This repo is unstable and unnecessary: https://github.com/microsoft/linux-package-repositories/issues/34
- name: Disable packages.microsoft.com repo
run: sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
- name: Get node_modules from cache
uses: actions/cache@v3
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"xterm-addon-attach": "^0.9.0",
"xterm-addon-fit": "^0.8.0",
"zod": "^3.22.4",
"zustand": "^4.4.7"
"zustand": "^4.5.0"
},
"devDependencies": {
"@ianvs/prettier-plugin-sort-imports": "^4.1.1",
Expand Down

0 comments on commit 4792105

Please sign in to comment.