Faucet Referral Codes #30
Open
+435
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
requested changes
Aug 2, 2024
Comment on lines
+193
to
+199
| db.prepare( | ||
| `CREATE INDEX IF NOT EXISTS operator_index ON ${TABLE.TRANSACTIONS} (${TRANSACTIONS_TABLE.WALLET}, ${TRANSACTIONS_TABLE.TIMESTAMP}) WHERE ${TRANSACTIONS_TABLE.WALLET} IS NOT NULL;` | ||
| ).run(); | ||
|
|
||
| db.prepare( | ||
| `CREATE INDEX IF NOT EXISTS operator_index ON ${TABLE.TRANSACTIONS} (${TRANSACTIONS_TABLE.TARGET}, ${TRANSACTIONS_TABLE.TIMESTAMP}, ${TRANSACTIONS_TABLE.CODE}) WHERE ${TRANSACTIONS_TABLE.CODE} IS NOT NULL;` | ||
| ).run(); |
There was a problem hiding this comment.
you've got two use 2 different names, otherwise the second one is never created!
| .prepare<string>( | ||
| `SELECT ${CODE_TABLE.ID}, ${CODE_TABLE.WALLET}, ${CODE_TABLE.DRIP}, ${CODE_TABLE.MAXUSES} FROM ${TABLE.CODE} WHERE ${CODE_TABLE.ID} = ?` | ||
| ) | ||
| .all(code)[0] as CodeDetails; |
There was a problem hiding this comment.
why not use
https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#getbindparameters---row
when you need one item at most and not all the rows?
| ); | ||
| } | ||
|
|
||
| const { wallet, maxuses, drip: codeDrip } = getReferralCodeDetails({ db, code }); |
Comment on lines
+240
to
+241
| codeTransactionHistory.filter((transaction) => transaction.target === targetAddress) | ||
| .length >= 1 |
There was a problem hiding this comment.
Suggested change
| codeTransactionHistory.filter((transaction) => transaction.target === targetAddress) | |
| .length >= 1 | |
| codeTransactionHistory.some((transaction) => transaction.target === targetAddress) |
Aerilym
added
enhancement
This was referenced Nov 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29