Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action panel button to mark all conversations as read. #2687

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

ianmacd
Copy link

@ianmacd ianmacd commented Feb 21, 2023

Contributor checklist:

By pressing the ✓ button in the action panel, the user can now mark all conversations as read.

This PR incidentally implements tool-tips for the action panel buttons, as pictured here:

markall1

On successful marking, a toast is displayed:

markall2

Fixes #2346.

@ianmacd ianmacd force-pushed the pr55 branch 4 times, most recently from 6e13497 to 9a37fa6 Compare February 23, 2023 08:00
@ianmacd
Copy link
Author

ianmacd commented Feb 23, 2023

I've now implemented a modal dialogue to allow the user to confirm the marking of all conversations as read.

image

@KeeJef
Copy link
Collaborator

KeeJef commented Feb 28, 2023

Generally think having a button to mark all conversations as read is a good idea, but not sure about the placement of the button in this design, the UX/UI team is going to look at some options on where we could place the button

@ianmacd
Copy link
Author

ianmacd commented Mar 5, 2023

Generally think having a button to mark all conversations as read is a good idea, but not sure about the placement of the button in this design, the UX/UI team is going to look at some options on where we could place the button

I'm not married to the location I used. I placed the button in the action panel because:

  • Other such buttons already existed, so I could see at a glance how to add another;
  • The action panel is chronically underutilised. There's a lot of unused vertical space, so it seems prudent to find new purposes for it.

@KeeJef
Copy link
Collaborator

KeeJef commented Mar 28, 2024

Wanted to do a temperature check on this one to see if people still feel this is a necessary feature now that we are syncing the read status of messages. For me, this has really cut down on the need to go through conversations and mark them as read on desktop.

@Bilb Bilb changed the base branch from clearnet to unstable September 30, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Global 'Mark all as read' option.
2 participants