Close cursor in retrieveConfigLastUpdateTimestamp (#1692)

oxen-io · Oct 14, 2024 · ecfa5d3 · ecfa5d3
1 parent ed1bddd
commit ecfa5d3
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/ConfigDatabase.kt b/app/src/main/java/org/thoughtcrime/securesms/database/ConfigDatabase.kt
@@ -44,10 +44,14 @@ class ConfigDatabase(context: Context, helper: SQLCipherOpenHelper): Database(co
     }
 
     fun retrieveConfigLastUpdateTimestamp(variant: String, publicKey: String): Long {
-        val db = readableDatabase
-        val cursor = db.query(TABLE_NAME, arrayOf(TIMESTAMP), VARIANT_AND_PUBKEY_WHERE, arrayOf(variant, publicKey),null, null, null)
-        if (cursor == null) return 0
-        if (!cursor.moveToFirst()) return 0
-        return (cursor.getLongOrNull(cursor.getColumnIndex(TIMESTAMP)) ?: 0)
+        return readableDatabase
+            .query(TABLE_NAME, arrayOf(TIMESTAMP), VARIANT_AND_PUBKEY_WHERE, arrayOf(variant, publicKey), null, null, null)
+            ?.use { cursor ->
+                if (cursor.moveToFirst()) {
+                    cursor.getLongOrNull(cursor.getColumnIndex(TIMESTAMP))
+                } else {
+                    null
+                }
+            } ?: 0L
     }
 }