Make close_gracefully public #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsession-util ran into an issue where the quic::Network destruction
segfaults because it has callbacks (e.g. connection closing) that expect
to be able to use their local `quic::Network` instance, but can't
because it's in the process of being destroyed.
Essentially the pattern is this:
class A {
quic::Network net;
};
A a;
// start a connection with a connection_close callback that
// references `a`.
If the quic::Network destruction is triggered by the destruction of `a`,
then the quic::Network destructor is firing *after* `a` is no longer in
a valid state, and so the callback referencing `a` is invalid.
Exposing close_gracefully() allows the application to deal with this: it
can add a `net.close_gracefully()` either in `A`'s destructor or some
other shutdown code so that it can ensure the quic Network shutdown
happens *before* `a` becomes unusable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsession-util ran into an issue where the quic::Network destruction segfaults because it has callbacks (e.g. connection closing) that expect to be able to use their local
quic::Networkinstance, but can't because it's in the process of being destroyed.Essentially the pattern is this:
If the quic::Network destruction is triggered by the destruction of
a, then the quic::Network destructor is firing afterais no longer in a valid state, and so the callback referencingais invalid.Exposing close_gracefully() allows the application to deal with this: it can add a
net.close_gracefully()either inA's destructor or some other shutdown code so that it can ensure the quic Network shutdown happens beforeabecomes unusable.