Add static submodule libs to bundled libsession-util #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
force-pushed
the
bundle-static-deps
branch
from
132fe75 to
7441307
Compare
This automatically adds anything that we include via submodules (and dependent libraries) into the libsession-util bundled library, most notably included libquic (in other upcoming PRs) and its various dependencies. This rewrites the libsession_static_bundle function so that: - targets recurse into dependencies of the target - only static libraries are actually added to the bundled lib list so that interface libraries and whatnot just get recursed, but not actually added as libraries, so that things like oxenc::oxenc (which is header-only) can safely go through the function.
jagerman
force-pushed
the
bundle-static-deps
branch
from
7441307 to
44c2033
Compare
mpretty-cyro
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically adds anything that we include via system_or_submodule into the libsession-util bundled library, most notably included libquic (in other upcoming PRs).
It also updates the libsession_static_bundle function so that only static library targets are actually bundled so that passing things like oxenc::oxenc (which is header-only and so not a static lib) just get silently ignored.