Add support for fetching chainIds from all providers at once #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used in oxen-core to verify that all configured providers are on the proper network. - Unifies code between getAllHeights, getAllChainIds which are pretty much identical. - Renames/redirects the current `getNetworkChainId` to `getChainId` and updates it to accesses via the `eth_chainId` endpoint rather than the ETH-deprecated `net_version` endpoint.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in oxen-core to verify that all configured providers are on the proper network during startup.
getNetworkChainIdtogetChainIdand updates it to accesses via theeth_chainIdendpoint rather than the ETH-deprecatednet_versionendpoint.