Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/class-properties): transform private in expression #8202

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 31, 2024

This PR support transforms #prop in object in class-properties to cover https://www.npmjs.com/package/@babel/plugin-transform-private-property-in-object plugin does

Copy link
Member Author

Dunqing commented Dec 31, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 12-31-chore_transformer_enable_babel_s_private-property-in-property_plugin_tests branch from dd857f7 to f6ea574 Compare December 31, 2024 10:49
@Dunqing Dunqing force-pushed the 12-31-feat_transformer_class-properties_transform_private_in_expression branch from 709583f to 1563017 Compare December 31, 2024 10:49
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 31, 2024
@Dunqing Dunqing force-pushed the 12-31-chore_transformer_enable_babel_s_private-property-in-property_plugin_tests branch from f6ea574 to cde89df Compare December 31, 2024 11:03
@Dunqing Dunqing force-pushed the 12-31-feat_transformer_class-properties_transform_private_in_expression branch from 1563017 to 26dad2f Compare December 31, 2024 11:03
Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #8202 will degrade performances by 6.74%

Comparing 12-31-feat_transformer_class-properties_transform_private_in_expression (0592a8b) with main (4804933)

Summary

❌ 1 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 12-31-feat_transformer_class-properties_transform_private_in_expression Change
transformer[pdf.mjs] 10.3 ms 11.1 ms -6.74%

@Dunqing Dunqing marked this pull request as ready for review December 31, 2024 12:28
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 31, 2024
Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

@Dunqing Dunqing force-pushed the 12-31-chore_transformer_enable_babel_s_private-property-in-property_plugin_tests branch from cde89df to 80c1652 Compare December 31, 2024 12:37
@Dunqing Dunqing force-pushed the 12-31-feat_transformer_class-properties_transform_private_in_expression branch from 26dad2f to 0592a8b Compare December 31, 2024 12:38
Base automatically changed from 12-31-chore_transformer_enable_babel_s_private-property-in-property_plugin_tests to main December 31, 2024 13:35
@graphite-app graphite-app bot merged commit 0592a8b into main Dec 31, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 12-31-feat_transformer_class-properties_transform_private_in_expression branch December 31, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant