-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix failed publish caused by cyclic dev dependencies #4416
chore: fix failed publish caused by cyclic dev dependencies #4416
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Or we could remove |
Do we have a way to verify this is work |
I don't know, cc @Boshen |
Because the dev cyclic dependency still exists, you can't make sure if this works until you try to make a new release, AFAIK, this is probably the best workaround, since |
1. This looks like caused by rust-lang/cargo#4242 1. rust-lang/futures-rs#2305
1. This looks like caused by rust-lang/cargo#4242 1. rust-lang/futures-rs#2305
Ref