Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failed publish caused by cyclic dev dependencies #4416

Merged

Conversation

Copy link

graphite-app bot commented Jul 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@IWANABETHATGUY IWANABETHATGUY requested review from Boshen and Dunqing July 23, 2024 03:41
@IWANABETHATGUY
Copy link
Contributor Author

@Dunqing
Copy link
Member

Dunqing commented Jul 23, 2024

Do we have a way to verify this is work

@IWANABETHATGUY
Copy link
Contributor Author

I don't know, cc @Boshen

@IWANABETHATGUY
Copy link
Contributor Author

Because the dev cyclic dependency still exists, you can't make sure if this works until you try to make a new release, AFAIK, this is probably the best workaround, since future-rs and many linked pull request also use this trick.

@Dunqing Dunqing changed the title fix: failed publish caused by cyclic dev depdency chore: fix failed publish caused by cyclic dev depdency Jul 23, 2024
@Dunqing Dunqing changed the title chore: fix failed publish caused by cyclic dev depdency chore: fix failed publish caused by cyclic dev dependencies Jul 23, 2024
@Dunqing Dunqing merged commit 01f33cf into oxc-project:main Jul 23, 2024
13 checks passed
@Dunqing
Copy link
Member

Dunqing commented Jul 23, 2024

@IWANABETHATGUY IWANABETHATGUY deleted the fix/cycle-dev-dependency-failed-ci branch July 23, 2024 06:59
Dunqing added a commit that referenced this pull request Jul 23, 2024
Dunqing added a commit that referenced this pull request Jul 23, 2024
…#4419)

Reverts #4416

This trick doesn't work for crates that have circular dependencies on
each other that all need to be published!
DonIsaac pushed a commit that referenced this pull request Jul 23, 2024
…#4419)

Reverts #4416

This trick doesn't work for crates that have circular dependencies on
each other that all need to be published!
DonIsaac pushed a commit that referenced this pull request Jul 24, 2024
…#4419)

Reverts #4416

This trick doesn't work for crates that have circular dependencies on
each other that all need to be published!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants