Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Release crates v0.22.0" #4415

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 23, 2024

Reverts #4414

Copy link

graphite-app bot commented Jul 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-cfg Area - Control Flow Graph A-isolated-declarations Isolated Declarations labels Jul 23, 2024
@Dunqing Dunqing merged commit c1cf0e6 into main Jul 23, 2024
24 checks passed
@Dunqing Dunqing deleted the revert-4414-release/crates-1721688488 branch July 23, 2024 01:59
Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #4415 will not alter performance

Comparing revert-4414-release/crates-1721688488 (eed6718) with main (68efcd4)

Summary

✅ 32 untouched benchmarks

@IWANABETHATGUY
Copy link
Contributor

It looks like cargo doesn't allow publishing crates with cyclic dev-dependencies, rust-lang/cargo#4242, there are some workarounds:
madsmtm/objc2@5a89184
https://github.com/entropyxyz/entropy-core/pull/837/files

@IWANABETHATGUY
Copy link
Contributor

We could use path instead of workspace,
https://github.com/oxc-project/oxc/blob/main/crates/oxc_mangler/Cargo.toml#L31

DonIsaac pushed a commit that referenced this pull request Jul 23, 2024
DonIsaac pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-cfg Area - Control Flow Graph A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-minifier Area - Minifier A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants