goMarkableStream ♥ reveal.js #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (99.2%)
Files: 30
Issues: 1
gofmt: 100%
go_vet: 100%
gocyclo: 96%
internal/eventhttphandler/gesture_handler.go
Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 96%
internal/eventhttphandler/gesture_handler.go
Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
| } | ||
|
|
||
| // ServeHTTP implements http.Handler | ||
| func (h *GestureHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
| "github.com/owulveryck/goMarkableStream/internal/pubsub" | ||
| ) | ||
|
|
||
| type SwipeDirection string |
There was a problem hiding this comment.
warning: exported type SwipeDirection should have comment or be unexported (golint)
| type SwipeDirection string | ||
|
|
||
| const ( | ||
| SwipeLeft SwipeDirection = "Swipe Left" |
There was a problem hiding this comment.
warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: a basic gesture detection has been implemented in the server and is available at the /gestures endpoint
The client analyse the gesture and on left and right send a post message to the iframe.
If the iframe contains a reveal.js presentation, the slides are changing