-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for Remarkable Paper Pro #122
Add initial support for Remarkable Paper Pro #122
Conversation
90564db
to
c2c328b
Compare
c2c328b
to
69c9947
Compare
This is some impressive work! Well done. I've tried to run it on my own device, but unfortunately I'm having some issues. I ran My device is on the beta version 17. When running, it displays the IP address but nothing else
No service is running on port Are there any debugging options to generate some useful output to help rectify this issue? |
Works fine on my device which is running 3.16.2.3. |
That's good, what output does it give? |
I've just downgraded my device to 3.16.1.0 and I can confirm it spins up the webserver, looks like potentially something on the beta is breaking it. If anybody else is on v17, would appreciate the test.
Here's the output it should give. |
That's me, in the last commit I broke it by changing the screen size constants. Can you check again please? I pushed the fix. |
Whooo, that worked! |
Awesome; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work!
let flip = getQueryParam('flip'); | ||
flip = flip !== null ? flip === 'true' : false; | ||
|
||
defaultFlip = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On RM2 the defaultFlip should be false as well (otherwise the image is upside down)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it
I've tested also on v17 and it is blocked after giving local ip address (but this information is very early in the code). So, for now i don't know what is blocking anyway, thanks for the great work here |
A lot of it is thanks to the incredible work of many contributors from #117, including @owulveryck, @cristiannobili, @danielealbano, @To-Si, @Jayy001, @hegzploit and more 😄
What currently does not work
Rotate
button in the UIColors
buttonAt least this, maybe something else.
Main changes
Because RLE isn't supported, I added optional zstd compression middleware alongside the existing gzip. It’s faster and should use less cpu.
ARM64 support
const_arm64.go
with device-specific constants for the Remarkable Paper Pro.fb_arm.go
renamed tofb_rm.go
and the build tags updated to support both arm and arm64.Framebuffer pointer calculation for RMPP
The logic is taken from #117 (comment) and #117 (comment).
Client side (JS) changes
screenWidth
,screenHeight
,UseRLE
, etc. from the backend to the JS client.Input devices
RMPP uses
/dev/input/event2
and/dev/input/event3
, so added these to the device-specific constants.To run the app on Paper Pro you need to disable the RLE and you can optionally enable the compression:
There's also a good possibility that the Remarkable 2 is broken. I'd appreciate it if someone could check.