Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Store federated ocis user and token for e2e tests #11796

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[tests-only][full-ci]Store federated ocis user and token for e2e tests #11796

merged 1 commit into from
Oct 22, 2024

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Oct 18, 2024 •
edited
Loading

Description

This PR update store for federated oCIS instance. On follow-up PR, tests related to oCIS federation will be added.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha self-assigned this Oct 18, 2024
@amrita-shrestha amrita-shrestha marked this pull request as ready for review October 21, 2024 09:08
saw-jan
saw-jan reviewed Oct 22, 2024
View reviewed changes
tests/e2e/cucumber/environment/index.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/environment/index.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/environment/index.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/features/ocm/ocm.feature Outdated Show resolved Hide resolved
tests/e2e/cucumber/features/ocm/ocm.feature Outdated Show resolved Hide resolved
tests/e2e/cucumber/steps/ui/session.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/environment/index.ts Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the store-multiple-ocis-user branch 2 times, most recently from d034e2b to aa95d85 Compare October 22, 2024 09:08
saw-jan
saw-jan approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@amrita-shrestha amrita-shrestha merged commit 6ba6b95 into master Oct 22, 2024
3 checks passed
@amrita-shrestha amrita-shrestha deleted the store-multiple-ocis-user branch October 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@SagarGi SagarGi Awaiting requested review from SagarGi

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrita-shrestha @saw-jan