Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] Collaborative Editing on OCM #11680

Closed
ScharfViktor opened this issue Sep 30, 2024 · 6 comments
Closed

[test-only] Collaborative Editing on OCM #11680

ScharfViktor opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker QA:p2 QA:team

Comments

@ScharfViktor
Copy link
Contributor

we should have e2e test for collaborative editing one document between two ocis instances

@ScharfViktor
Copy link
Contributor Author

@amrita-shrestha is currently working on #11838 and #11823
we question the possibility of two ocm users editing a document together. @kulmann is it possible/needed ?

cc @saw-jan

@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Nov 6, 2024

in ocis @2403905 working on - owncloud/ocis#10420

@saw-jan
Copy link
Member

saw-jan commented Nov 6, 2024

in ocis @2403905 working on - #11838

do you mean to say owncloud/ocis#10420 ?
This issue is regarding collaborative editing with ocm and PR owncloud/ocis#10420 is about bringing ocm to ocis_full deployment example (which might/can exclude web office setup with ocm if not possible)

We briefly talked about the possibility.

CC @kulmann @2403905

@kulmann
Copy link
Member

kulmann commented Nov 6, 2024

@amrita-shrestha is currently working on #11838 and #11823 we question the possibility of two ocm users editing a document together. @kulmann is it possible/needed ?

cc @saw-jan

With the current implementation it's not possible so you don't need to add a test for this.

The original feature set of OCM includes a remote editing file action: remote editor gets opened with the OCM token. We disabled that feature in oCIS indefinitely because it's a security nightmare. The OCM token can't be revoked manually so if the link gets sent to someone access to the document is shared without the possibility to revoke it. This can happen via access log sniffing or by a human sending the editor link to someone else.

@saw-jan
Copy link
Member

saw-jan commented Nov 6, 2024

Should we close this ticket?

@micbar
Copy link
Contributor

micbar commented Nov 6, 2024

yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker QA:p2 QA:team
Projects
None yet
Development

No branches or pull requests

5 participants