Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some code syntax & style improvements #53

Merged
merged 26 commits into from
Aug 20, 2024
Merged

some code syntax & style improvements #53

merged 26 commits into from
Aug 20, 2024

Conversation

koebel
Copy link
Collaborator

@koebel koebel commented Aug 14, 2024 •
edited
Loading

Description

there have been some inconsistencies with ocis code style (naming conventions of page objects and helper files) and in the wording of user story

Related Issue

Motivation and Context

maintain consistency in naming conventions and wording

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added/changed

koebel and others added 14 commits August 14, 2024 16:22
@koebel
adding error if trashbin wasn't deleted properly
41ff2f9
@koebel
adding error if file hasn't been properly deleted
d1571bc
@koebel
removing unnecessary return values
7ff32d4
@koebel
adding try & catch to API request
4ed9e13
@koebel
remove purple border around dicom image
82ded73
@koebel
change flip icon
9eb5a2e
@koebel
improve readability of code
69ebf41
@koebel
Merge pull request #57 from owncloud/change-icons-for-flip-image
749f281 
update icon for flipping image
@koebel
figure out how to refresh viewport after changing parallel scale factor
508368e
@Salipa-Gurung
add missing mock function
c5d583a
@koebel
Merge pull request #59 from owncloud/unit-test-missing-mock
6dfbe0c 
Add missing mock function
@koebel
add setZoom back
3aacc19
@koebel
correcting the parallel scale factor in mocks to match with changes i…
70722a9 
…n implementation
@koebel
Merge pull request #56 from owncloud/initial-scale-factor-of-preview
12df68f 
remove purple border around dicom image preview
@koebel
Merge pull request #54 from owncloud/error-checking-for-helper-functions
e528bd1 
adding error checking for hooks & API helper functions
@koebel koebel requested a review from phil-davis August 20, 2024 05:00
@phil-davis
Copy link
Contributor

"This branch is 4 commits ahead of, 15 commits behind main."

Needs a rebase and resolve conflicts.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@koebel koebel merged commit 88f551d into main Aug 20, 2024
2 checks passed
@koebel koebel deleted the code-syntax-&-style-improvements branch August 20, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koebel @phil-davis @Salipa-Gurung