Merge pull request #54 from owncloud/error-checking-for-helper-functions

adding error checking for hooks & API helper functions

tests/e2e/api/APIHelper.ts

@@ -3,17 +3,20 @@ import axios from 'axios'
 import join from 'join-path'
 
 export const sendRequest = function ({ method, path, header = null, data = null }): Promise<any> {
-  const headers = {
-    ...header,
-    Authorization: `Basic ${Buffer.from(`${config.adminUser}:${config.adminPassword}`).toString(
-      'base64'
-    )}`
+  try {
+    const headers = {
+      ...header,
+      Authorization: `Basic ${Buffer.from(`${config.adminUser}:${config.adminPassword}`).toString(
+        'base64'
+      )}`
+    }
+    return axios({
+      method,
+      url: join(config.baseUrlOcis, path),
+      headers,
+      data
+    })
+  } catch (error) {
+    throw new Error(error.message)
   }
-
-  return axios({
-    method,
-    url: join(config.baseUrlOcis, path),
-    headers,
-    data
-  })
 }

tests/e2e/hooks.ts

@@ -36,10 +36,21 @@ const deleteDicomFile = async function (): Promise<void> {
   const result = xml2js(xmlResponse, { compact: true })
   const resp = _.get(result, 'd:multistatus.d:response')
   const href = _.get(resp[1], 'd:href._text')
-
-  await sendRequest({ method: 'DELETE', path: href })
+  const response2 = await sendRequest({
+    method: 'DELETE',
+    path: href
+  })
+  if (response2.status !== 204) {
+    throw new Error(`Failed to delete dicom file`)
+  }
 }
 
 const emptyTrashbin = async function (): Promise<void> {
-  await sendRequest({ method: 'DELETE', path: 'remote.php/dav/trash-bin/admin' })
+  const response = await sendRequest({
+    method: 'DELETE',
+    path: 'remote.php/dav/trash-bin/admin'
+  })
+  if (response.status !== 204) {
+    throw new Error(`Failed to empty trashbin`)
+  }
 }