Do not disable/reenable non-shipped apps

[VicDeo]

Web Updater continues to disable/reenable non-shipped apps. This PR fixes that.
This should be in 10.0 IMO.

Tested manually by copying files on top of 9.1.6 and updating to 10.0.2.1

Fixes disabling of encryption app described in #428

[davitol]

@VicDeo 👎 #428 Keeps reproducing. The default encryption module gets disabled.

[4nanook]

The apps don't even showed up in disabled apps.

[davitol]

The apps don't even showed up in disabled apps.

They are shown in my server. Enabling them again solved my problem

[4nanook]

Are you running PHP 5.x or 7.x?

…

-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_- Eskimo North Linux Friendly Internet Access, Shell Accounts, and Hosting. Knowledgeable human assistance, not telephone trees or script readers. See our web site: http://www.eskimo.com/ (206) 812-0051 or (800) 246-6874.

On Sun, 18 Jun 2017, David Toledo wrote: Date: Sun, 18 Jun 2017 23:36:04 -0700 From: David Toledo ***@***.***> Reply-To: owncloud/updater <reply+0034e62df51ebf20c176eb083547809d75efd581c26574c792cf00000001155f32d ***@***.***> To: owncloud/updater ***@***.***> Cc: Robert Dinse ***@***.***>, Comment ***@***.***> Subject: Re: [owncloud/updater] Do not disable/reenable non-shipped apps (#430) > The apps don't even showed up in disabled apps. They are shown in my server. Enabling them again solved my problem -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #430 (comment)

[davitol]

Are you running PHP 5.x or 7.x?

php 7.0

[4nanook]

Hmm, I enabled apps once, but they do not show up in the upper left like they used to even after enabling them.

…

-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_- Eskimo North Linux Friendly Internet Access, Shell Accounts, and Hosting. Knowledgeable human assistance, not telephone trees or script readers. See our web site: http://www.eskimo.com/ (206) 812-0051 or (800) 246-6874.

On Sun, 18 Jun 2017, David Toledo wrote: Date: Sun, 18 Jun 2017 23:55:56 -0700 From: David Toledo ***@***.***> Reply-To: owncloud/updater <reply+0034e62d14154b71c6b1ad440e50be0796a2539163bcdf4892cf00000001155f377 ***@***.***> To: owncloud/updater ***@***.***> Cc: Robert Dinse ***@***.***>, Comment ***@***.***> Subject: Re: [owncloud/updater] Do not disable/reenable non-shipped apps (#430) > Are you running PHP 5.x or 7.x? php 7.0 -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #430 (comment)

[PVince81]

I agree with the approach, but it needs to work.

[VicDeo]

@PVince81 It works as advertised (Updater does not send app disabling/enabling requests to the core).
Without this PR all 3rdparty apps will be disabled with a probability of 100%.

May be something else in a different repo needs a special attention. Should we experience a composition of different issues or just let this in and go further?

[PVince81]

@VicDeo is there another way to confirm that this is working when testing, something that does not involve encryption to validate the current changes ?

[VicDeo]

@PVince81 manual testing. E.g. with encryption disabled.
I tested it on my own 9.1.6 to 10

[davitol]

Without this PR all 3rdparty apps will be disabled with a probability of 100%.

Let's merge this PR then