Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NOTIFICATIONS_WEB_UI_URL #4998

Merged
merged 2 commits into from
Nov 8, 2022
Merged

add NOTIFICATIONS_WEB_UI_URL #4998

merged 2 commits into from
Nov 8, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 7, 2022 •
edited
Loading

Description

We've fixed the configuration of the notification service's Web UI url that appears in emails.
Previously it was only configurable via the global "OCIS_URL" and is now also configurable via "NOTIFICATIONS_WEB_UI_URL".

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@mmattel
Copy link
Contributor

mmattel commented Nov 8, 2022

Env description text looks fine 👍

@mmattel
Copy link
Contributor

mmattel commented Nov 8, 2022

@wkloucek maybe you want sonarcloud to either shut up or adopt the casing for the variable 😄

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 321004d into owncloud:master Nov 8, 2022
ownclouders pushed a commit that referenced this pull request Nov 8, 2022
@mmattel
commit 321004d
da08853 
Merge: a5b2bb1 61be11a
Author: Martin <[email protected]>
Date:   Tue Nov 8 15:24:13 2022 +0100

    Merge pull request #4998 from wkloucek/fix-notifications-ocis-url

    add NOTIFICATIONS_WEB_UI_URL
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
@ScharfViktor ScharfViktor mentioned this pull request Nov 28, 2022
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel left review comments

@kobergj kobergj kobergj approved these changes

@dragonchaser dragonchaser dragonchaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkloucek @mmattel @dragonchaser @kobergj