Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add tests to remove access of shared resource to federated user #10672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds tests to remove access of a shared resource to federated user( both local and remote).

Scenario: local user deletes access of shared resource to federated user
Scenario: federation user deletes access of shared resource to local user

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-delete-share branch 4 times, most recently from e3266d0 to 7ba257a Compare November 28, 2024 08:47
@prashant-gurung899
Copy link
Contributor Author

prashant-gurung899 commented Nov 29, 2024

This PR is on hold because of bug; #10689
So, moving it to blocked for now.

Copy link

sonarcloud bot commented Nov 29, 2024

@@ -1808,16 +1808,22 @@ public function checkIfShareExists(string $share, string $sharee, string $sharer
}

/**
* @Then user :sharee should have a share :share shared by user :sharer
* @Then /^user "([^"]*)" should (not |)have a share "([^"]*)" shared by user "([^"]*)"$/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @Then /^user "([^"]*)" should (not |)have a share "([^"]*)" shared by user "([^"]*)"$/
* @Then /^user "([^"]*)" (should|should not) have a share "([^"]*)" shared by user "([^"]*)"$/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants