-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] add tests to remove access of shared resource to federated user #10672
Open
prashant-gurung899
wants to merge
1
commit into
master
Choose a base branch
from
tests-ocm-delete-share
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
2 times, most recently
from
November 27, 2024 08:29
f9f042c
to
7e37e5a
Compare
prashant-gurung899
requested review from
anon-pradip,
saw-jan,
amrita-shrestha,
S-Panta,
PrajwolAmatya and
nirajacharya2
November 27, 2024 09:12
saw-jan
reviewed
Nov 28, 2024
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
4 times, most recently
from
November 28, 2024 08:47
e3266d0
to
7ba257a
Compare
saw-jan
reviewed
Nov 28, 2024
Signed-off-by: prashant-gurung899 <[email protected]>
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
from
November 29, 2024 08:49
7ba257a
to
7135198
Compare
This PR is on hold because of bug; #10689 |
Quality Gate passedIssues Measures |
@@ -1808,16 +1808,22 @@ public function checkIfShareExists(string $share, string $sharee, string $sharer | |||
} | |||
|
|||
/** | |||
* @Then user :sharee should have a share :share shared by user :sharer | |||
* @Then /^user "([^"]*)" should (not |)have a share "([^"]*)" shared by user "([^"]*)"$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* @Then /^user "([^"]*)" should (not |)have a share "([^"]*)" shared by user "([^"]*)"$/ | |
* @Then /^user "([^"]*)" (should|should not) have a share "([^"]*)" shared by user "([^"]*)"$/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests to remove access of a shared resource to federated user( both local and remote).
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: