[fix/fastlane-release-12.3] Adopt Fastlane to xcstrings usage

changelog/unreleased/1377 → changelog/12.3.0_2024-09-23/1377

@@ -1,4 +1,4 @@
-Bugfix: Remove (re)sharing from roles for newly created user/group shares for ocis
+Bugfix: Remove (re)sharing from roles for newly created user/group shares
 
 Removes (re)sharing from roles for newly created user/group shares for ocis.
 

fastlane/Fastfile

@@ -627,8 +627,30 @@ end
     set_info_plist_value(path: "ownCloud Action Extension/Info.plist", key: "CFBundleDisplayName", value: "Save to " + appName)
     set_info_plist_value(path: "ownCloud Action Extension/Info.plist", key: "CFBundleName", value: appName)
 
-    sh("sed -i '' '/\"CFBundleDisplayName\" =/s/ownCloud/#{appName}/' '../ownCloud Action Extension/en.lproj/InfoPlist.strings'")
-    sh("sed -i '' '/\"CFBundleDisplayName\" =/s/ownCloud/#{appName}/' '../ownCloud Action Extension/de.lproj/InfoPlist.strings'")
+    # Read InfoPlist.xcstrings JSON content from the file
+    json_file_path = "../ownCloud Action Extension/InfoPlist.xcstrings"
+    json_content = File.read(json_file_path)
+    json_data = JSON.parse(json_content)
+
+    # Update the CFBundleDisplayName value for all localizations
+    if json_data["strings"] && json_data["strings"]["CFBundleDisplayName"]
+        UI.message("CFBundleDisplayName key found, updating values...")
+
+        json_data["strings"]["CFBundleDisplayName"]["localizations"].each do |locale, localization_data|
+          old_value = localization_data["stringUnit"]["value"]
+
+          # Replace "ownCloud" with appName
+          new_value = old_value.gsub("ownCloud", appName)
+          localization_data["stringUnit"]["value"] = new_value
+        end
+      else
+        UI.error("CFBundleDisplayName key not found in the JSON data!")
+      end
+
+    # Write the updated JSON back to the file
+    File.open(json_file_path, "w") do |f|
+      f.write(JSON.pretty_generate(json_data))
+    end
 
     update_app_identifier(
       xcodeproj: "ownCloud.xcodeproj",

fastlane/metadata-emm/en-US/release_notes.txt

@@ -1,3 +1,6 @@
-• Security Fix
-Detect attempts to bypass a lock timeout by changing the clock
+• iOS 18
+The app is now compatible with iOS 18.
+
+• General Improvements
+General app improvements and internal fixes to enhance performance, synchronization, and stability.
 

fastlane/metadata-owncloud-online/en-US/release_notes.txt

@@ -1,2 +1,6 @@
-• Security Fix
-Detect attempts to bypass a lock timeout by changing the clock
+• iOS 18
+The app is now compatible with iOS 18.
+
+• General Improvements
+General app improvements and internal fixes to enhance performance, synchronization, and stability.
+

fastlane/metadata/en-US/release_notes.txt

@@ -1,2 +1,6 @@
-• Security Fix
-Detect attempts to bypass a lock timeout by changing the clock
+• iOS 18
+The app is now compatible with iOS 18.
+
+• General Improvements
+General app improvements and internal fixes to enhance performance, synchronization, and stability.
+