-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/reduce-mem-footprint] Reduce memory footprint #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors in HTTP layer
- ProgressView: add minimum + touch friendly sizes to avoid display as zero-sized views (which prevented cancelling by tapping because the touch never reached the view)
- AvailableOfflineAction: fix bug where a folder selected for Available Offline could not be removed form Available Offline by action (due to Swift != comparison apparently not using -isEqual:)
- fix protocol warnings new in Xcode 16 - adopt newer #unavailable syntax instead of if #available { /* Nothing */ } else { /* Code*/ }
…amework as a dependency - and thereby its dependencies, especially OpenSSL.framework, which adds to the memory footprint. The dependency on ownCloudApp is removed by adding the few parts relevant to the FileProvider to the FileProvider target and directly including the respective header files. - MediaUploadOperation: no longer use File Provider for imports from the photo library due to stability issues
|
19 tasks
3 tasks
- ProgressSummarizer: add method to reset priority summaries - AccountConnection: clear priority summaries after disconnect to return them to a defined state (fixes "Connecting…" being shown forever after a re-login)
- FileProviderExtension: fix spurious "invalid parameter" error on import
3 tasks
…downloading folder items
- rewrite/refactor to upload files directly from the extension rather than through the File Provider - automatically try to avoid name collisions on upload - ProgressIndicatorViewController: - fix lack of themeing by adding the modal CSS selector to the view controller - update the displayed progress from the Progress instance set on the .progress property
- Intents.intentdefinition: remove File Provider upload option for SaveIntentHandler
hosy
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
ownCloudApp
and its dependencies (likeOpenSSL.framework
). This increases the amount of memory available to the File Provider after loading, thereby also improving stability.SaveFileIntent
(Apple Shortcuts integration)ProgressSummarizer
after disconnectPaired with owncloud/ios-sdk#110.
Types of changes