Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/xcode-16] Fixes for iOS/iPadOS 18 and Xcode 16 #1374

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented Aug 13, 2024

Description

This PR contains fixes to make the app run on iOS/iPadOS 18 and Xcode 16.

Temporarily targets #1351 instead of master to allow seeing only the changes until that branch is merged to master.

Related Issue

#1371

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@felix-schwarz felix-schwarz changed the base branch from master to feature/better-sync August 13, 2024 15:37
@felix-schwarz felix-schwarz self-assigned this Aug 13, 2024
@jesmrec
Copy link
Contributor

jesmrec commented Aug 14, 2024

This branch...

  • ... builds with Xcode 15.4 vs iOS 17 ✅
  • ... builds with Xcode 16.1-beta vs iOS 17 ✅
  • ... archives with Xcode 15.4 vs iOS 17 ✅
  • ... archives with Xcode 16.1-beta vs iOS 17 ✅
  • ... builds with Xcode 16.1-beta vs iOS 18-beta ✅

- fix protocol warnings new in Xcode 16
- adopt newer #unavailable syntax instead of if #available { /* Nothing */ } else { /* Code*/ }
@jesmrec
Copy link
Contributor

jesmrec commented Aug 20, 2024

I did a new check over the scenarios above 👆 with success. It's OK from my side.

@felix-schwarz felix-schwarz merged commit 7de851b into feature/better-sync Aug 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants