Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/remove-intents-extension] Remove Extension Build Flag (Intents) #1307

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Dec 1, 2023

Description

This PR adds a possibility to remove app extensions from a IPA build.

For the related issue it is needed to remove the ownCloud Intents extension to remove Shortcuts and Siri support from the ownCloud app.

Related Issue

https://github.com/owncloud/enterprise/issues/6112

Motivation and Context

How Has This Been Tested?

Add this key/value pair to the Branding.plist file and build the app via fastlane:

	<key>build.flags</key>
	<string>REMOVE_EXTENSION_INTENTS</string>
fastlane release_on_appstore create_release_notes:false create_screenshots:false build_regular_app:true build_emm_app:false build_owncloud_online_app:false deliver:false

This will execute the new shell script removeExtension.sh with the following parameter:

../removeExtension.sh "../ownCloud-regular-12.0.3-feature_remove-intents-extension-app-store-xy.ipa" "ownCloud Intents"

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@hosy hosy added this to the 12.1-Current milestone Dec 1, 2023
@hosy hosy self-assigned this Dec 1, 2023
@hosy hosy requested review from felix-schwarz and jesmrec December 1, 2023 10:45
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesmrec jesmrec mentioned this pull request Dec 5, 2023
36 tasks
@hosy hosy merged commit 70980cb into feature/account-wizard Dec 11, 2023
3 of 5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/remove-intents-extension branch December 11, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Branding / build option to release app without iOS system integration "Siri & Search"
4 participants