Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added bug demo for removing comments app from whitelist for guest users #558

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[tests-only][full-ci] added bug demo for removing comments app from whitelist for guest users #558

merged 1 commit into from
Apr 11, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Mar 31, 2023 •
edited
Loading

Description

This PR adds bug demonstration test for removing comments app from the whitelist for guest users, so that guest users cannot add, view or delete comments of a resource.

Related Issue

Related to issue: #549

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test added

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PrajwolAmatya PrajwolAmatya self-assigned this Mar 31, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Mar 31, 2023
Open
@PrajwolAmatya PrajwolAmatya force-pushed the bug-demo-test-for-removing-comments-from-whitelist branch from a79f3eb to 9dca3ae Compare March 31, 2023 08:32
@PrajwolAmatya PrajwolAmatya force-pushed the bug-demo-test-for-removing-comments-from-whitelist branch from 9dca3ae to 9d7d01f Compare March 31, 2023 11:23
SagarGi
SagarGi reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

grgprarup
grgprarup reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PrajwolAmatya PrajwolAmatya force-pushed the bug-demo-test-for-removing-comments-from-whitelist branch from 9d7d01f to da1829e Compare April 3, 2023 08:15
SagarGi
SagarGi reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PrajwolAmatya PrajwolAmatya force-pushed the bug-demo-test-for-removing-comments-from-whitelist branch from da1829e to b2a622a Compare April 4, 2023 09:34
amrita-shrestha
amrita-shrestha reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others lgtm

tests/acceptance/features/apiGuests/guests.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiGuests/guests.feature Show resolved Hide resolved
tests/acceptance/features/apiGuests/guests.feature Outdated Show resolved Hide resolved
@PrajwolAmatya PrajwolAmatya force-pushed the bug-demo-test-for-removing-comments-from-whitelist branch from b2a622a to b6c53f1 Compare April 5, 2023 03:52
@PrajwolAmatya PrajwolAmatya force-pushed the bug-demo-test-for-removing-comments-from-whitelist branch from b6c53f1 to c5fcadb Compare April 6, 2023 10:34
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrajwolAmatya PrajwolAmatya merged commit d20e89f into master Apr 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the bug-demo-test-for-removing-comments-from-whitelist branch April 11, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrajwolAmatya @grgprarup @SwikritiT @SagarGi @saw-jan @amrita-shrestha