Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent/Parallel user sharing #15

Closed
wants to merge 4 commits into from
Closed

Concurrent/Parallel user sharing #15

wants to merge 4 commits into from

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Oct 3, 2023 •
edited
Loading

Description

This PR adds a sample API test for concurrent user sharing.
For now this test adds only a single share of resource to 5 of the existing user concurrently.

Related Issue:

owncloud/QA#828

@SagarGi SagarGi self-assigned this Oct 9, 2023
@SagarGi SagarGi added the QA:team label Oct 9, 2023
@SagarGi SagarGi changed the title Check Concurrent/Parallel user sharing Oct 9, 2023
@SagarGi
Copy link
Member Author

SagarGi commented Oct 9, 2023 •
edited
Loading

Some Findings regarding the implementation of Concurrent user sharing using cs3api:

  1. Currently concurrent sharing is done only for 5 users. It would have been good if we have more users to share concurrently. i am unable to find the request to create user through cs3api or also the available client for as says it is unimplemented
  2. Also we need each sharee information to share. So to get the information of the created user we need to find each user information.

@SagarGi SagarGi marked this pull request as ready for review October 9, 2023 08:34
ScharfViktor
ScharfViktor reviewed Oct 11, 2023
View reviewed changes
features/concurrent-user-sharing.feature Outdated Show resolved Hide resolved
features/concurrent-user-sharing.feature Outdated Show resolved Hide resolved
features/concurrent-user-sharing.feature Outdated
And user "admin" has created a personal space with the alias "Admin Home"
And user "admin" has uploaded a file "testfile1.txt" with content "concurrent sharing" in the home directory with the alias "testfile1"
And user "admin" has uploaded a file "testfile2.txt" with content "concurrent sharing" in the home directory with the alias "testfile2"
When user "admin" shares a file "testfile1.txt" with the following users concurrently
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find how create new users. I don't know if it's possible to do it here.
as a trick to increase a shares count can also be shared with demo groups

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @butonic. If you could provide some details regarding the creation of the users.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot create more users. @SagarGi please add all existing group and we can merge PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor sure!

@SagarGi SagarGi mentioned this pull request Dec 3, 2023
Open
@SagarGi
Copy link
Member Author

SagarGi commented Dec 3, 2023

Not very urgent thing to do right now. Can be done later. So moving to backlog.

@SagarGi SagarGi removed their assignment Dec 3, 2023
@SagarGi
Copy link
Member Author

SagarGi commented Dec 22, 2023

Since we cannot create more users with the cs3api. The main objective of this PR or issue was to include more users as much as possible and prepare the concurrency of the share for the created users. So concurrent sharing with only few users does not seem valid. May be we can achieve the thing with API tests in the ocis itself. So closing this PR.

@SagarGi SagarGi closed this Dec 22, 2023
@saw-jan saw-jan deleted the concurent_user_sharing branch December 22, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor left review comments

Assignees
No one assigned
Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagarGi @ScharfViktor