lookup in group principal backend as well

[DeepDiver1975]

Description

The repair step RemoveInvalidShares was not respecting group shares and deleted them.

Related Issue

• fixes Deleting Calendar Sharing #33216

Test Steps

• share calendar with a group
• run the repairstep (basically increase the version in version.php to trigger upgrade)
• ensure the calendar is still shared with the group

How Has This Been Tested?

• unit test

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[DeepDiver1975]

@georgeoftown interested in helping to test this?

[georgeoftown]

@georgeoftown interested in helping to test this?

Sure, tell us what you want us to do

[DeepDiver1975]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[codecov]

Codecov Report

Merging #33245 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #33245      +/-   ##
============================================
+ Coverage     64.02%   64.03%   +<.01%     
- Complexity    18187    18188       +1     
============================================
  Files          1179     1179              
  Lines         68698    68701       +3     
  Branches       1271     1271              
============================================
+ Hits          43987    43990       +3     
  Misses        24341    24341              
  Partials        370      370

Flag	Coverage Δ	Complexity Δ
#javascript	52.88% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.33% <100%> (ø)	18188 <0> (+1)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/Repair/RemoveInvalidShares.php	100% <100%> (ø)	7 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0871ca...da295fc. Read the comment docs.

[DeepDiver1975]

Sure, tell us what you want us to do

Let me know if the test steps as written in the description are enough - THX

[georgeoftown]

Sure, tell us what you want us to do

Let me know if the test steps as written in the description are enough - THX

hi.
In the second step is necesary touch the version of the app dav in the table oc_appConfig (mysql) to be executed the Repair steps
select * from oc_appconfig where appid="dav";
Change 0.4.0 to 0.3.9

appid	configkey	configvalue
dav	enabled	yes
dav	installed_version	0.4.0
dav	types	filesystem

update oc_appconfig set configvalue="0.3.9" where appid="dav" and configkey="installed_version";

[DeepDiver1975]

THX @georgeoftown - what are the results of your testing? THX

[PVince81]

👍 makes sense.

backport ?

[DeepDiver1975]

Will do backport ....

[phil-davis]

Backport stable10 #33394