fix: http header keys are case in-sensitive #11992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to get response bodies printed into the log file in case the http response keys are al lower case.
Background: comparing keys case sensitive is wrong as http header keys are case in-sensitive as per definition:
https://www.rfc-editor.org/rfc/rfc7230#section-3.2
A true fix requires to work on QNetworkReply::headers(), QHttpHeaders::value() and QHttpHeaders::WellKnownHeader::ContentType .... but this raises the Qt minimum version to 6.8 due to replay->headers()
https://doc.qt.io/qt-6/qnetworkreply.html#headers