Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop synchronisation when behind a captive portal #11567

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Stop synchronisation when behind a captive portal #11567

merged 7 commits into from
Aug 21, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Mar 28, 2024

Fixes: #11533

@erikjv erikjv requested a review from TheOneRing March 28, 2024 17:33
@erikjv erikjv self-assigned this Mar 28, 2024
@erikjv erikjv marked this pull request as draft March 28, 2024 17:34
@erikjv
Copy link
Collaborator Author

erikjv commented Mar 28, 2024

The SpacesManager still needs to be hooked up. So maybe the Utility code needs to move to libsync.

TheOneRing
TheOneRing reviewed Apr 2, 2024
View reviewed changes
src/gui/guiutility.cpp Outdated Show resolved Hide resolved
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch 3 times, most recently from 2728dbe to 7dd72f4 Compare April 4, 2024 15:10
TheOneRing
TheOneRing reviewed Apr 5, 2024
View reviewed changes
src/gui/accountstate.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing reviewed Apr 5, 2024
View reviewed changes
src/gui/accountstate.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing reviewed Apr 5, 2024
View reviewed changes
src/gui/accountstate.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing reviewed Apr 5, 2024
View reviewed changes
src/gui/main.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing suggested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a manual testing action, it has quite a heavy impact on the client...

src/gui/owncloudgui.cpp Show resolved Hide resolved
src/libsync/accessmanager.cpp Outdated Show resolved Hide resolved
@TheOneRing
Copy link
Contributor

Brainstorming: We have multiple network information things to test, could it make sense to implement a custom one that wraps the native one and allows overriding values?

@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 7dd72f4 to f10d5eb Compare April 11, 2024 15:44
@erikjv erikjv requested a review from TheOneRing April 11, 2024 15:45
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch 2 times, most recently from 03c2325 to 4e85060 Compare April 15, 2024 13:56
@erikjv erikjv marked this pull request as ready for review April 15, 2024 14:03
@TheOneRing
Copy link
Contributor

Please rebase, once done I can start a review.

@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 5b1e182 to 412851f Compare April 16, 2024 13:55
TheOneRing
TheOneRing reviewed Apr 16, 2024
View reviewed changes
src/gui/networkinformation.cpp Outdated Show resolved Hide resolved
src/gui/accountstate.cpp Show resolved Hide resolved
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 412851f to 07efac2 Compare April 17, 2024 13:28
@erikjv erikjv requested a review from TheOneRing April 17, 2024 14:00
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch 2 times, most recently from 8920af8 to fdde86d Compare April 17, 2024 17:32
TheOneRing
TheOneRing suggested changes Apr 18, 2024
View reviewed changes
test/testutils/testutils.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing suggested changes Apr 18, 2024
View reviewed changes
src/gui/networkinformation.cpp Outdated Show resolved Hide resolved
src/gui/networkinformation.cpp Outdated Show resolved Hide resolved
src/gui/accountstate.cpp Outdated Show resolved Hide resolved
src/gui/accountstate.cpp Outdated Show resolved Hide resolved
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch 2 times, most recently from 8023f44 to d178dc3 Compare May 27, 2024 16:05
@erikjv erikjv requested a review from TheOneRing May 27, 2024 16:07
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from d178dc3 to 474a4e4 Compare June 12, 2024 13:32
TheOneRing
TheOneRing previously approved these changes Jun 12, 2024
View reviewed changes
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 3689e81 to 9d8dd74 Compare June 21, 2024 14:32
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 9d8dd74 to 7c15ca7 Compare August 13, 2024 15:46
@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 7c15ca7 to 888c835 Compare August 13, 2024 15:57
@erikjv
Copy link
Collaborator Author

erikjv commented Aug 14, 2024

See the screenshot in #11533 (comment)

@erikjv erikjv force-pushed the work/pause-sync-behind-captive-portal branch from 888c835 to 52f3132 Compare August 14, 2024 14:07
@erikjv erikjv requested a review from TheOneRing August 14, 2024 14:07
@erikjv erikjv modified the milestone: Desktop 6.0 Aug 14, 2024
TheOneRing
TheOneRing previously approved these changes Aug 15, 2024
View reviewed changes
@erikjv erikjv requested a review from TheOneRing August 16, 2024 12:26
@TheOneRing TheOneRing merged commit 2ebf7f0 into master Aug 21, 2024
4 of 6 checks passed
@TheOneRing TheOneRing deleted the work/pause-sync-behind-captive-portal branch August 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing Awaiting requested review from TheOneRing

Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect captive portal and pause sync
2 participants
@erikjv @TheOneRing