fix: replace deprecated qAsConst() by std::as_const() (#12011)

src/common/syncjournaldb.cpp

@@ -839,7 +839,7 @@ Result<void, QString> SyncJournalDb::setFileRecord(const SyncJournalFileRecord &
     if (!_etagStorageFilter.isEmpty()) {
         // If we are a directory that should not be read from db next time, don't write the etag
         QByteArray prefix = record._path + "/";
-        for (const auto &it : qAsConst(_etagStorageFilter)) {
+        for (const auto &it : std::as_const(_etagStorageFilter)) {
             if (it.startsWith(prefix)) {
                 qCInfo(lcDb) << "Filtered writing the etag of" << prefix << "because it is a prefix of" << it;
                 record._etag = "_invalid_";

src/csync/csync_exclude.cpp

@@ -275,7 +275,7 @@ bool ExcludedFiles::reloadExcludeFiles()
 {
     _allExcludes.clear();
     bool success = true;
-    for (const auto &file : qAsConst(_excludeFiles)) {
+    for (const auto &file : std::as_const(_excludeFiles)) {
         QFile f(file);
         if (!f.open(QIODevice::ReadOnly)) {
             success = false;
@@ -629,7 +629,7 @@ void ExcludedFiles::prepare()
         pattern.append(appendMe);
     };
 
-    for (auto exclude : qAsConst(_allExcludes)) {
+    for (auto exclude : std::as_const(_allExcludes)) {
         if (exclude[0] == QLatin1Char('\n'))
             continue; // empty line
         if (exclude[0] == QLatin1Char('\r'))

src/gui/accountmanager.cpp

@@ -202,7 +202,7 @@ bool AccountManager::restoreFromLegacySettings()
 
 void AccountManager::save(bool saveCredentials)
 {
-    for (const auto &acc : qAsConst(_accounts)) {
+    for (const auto &acc : std::as_const(_accounts)) {
         saveAccount(acc->account().data(), saveCredentials);
     }
 
@@ -328,7 +328,7 @@ AccountPtr AccountManager::loadAccountHelper(QSettings &settings)
 
 AccountStatePtr AccountManager::account(const QString &name)
 {
-    for (const auto &acc : qAsConst(_accounts)) {
+    for (const auto &acc : std::as_const(_accounts)) {
         if (acc->account()->displayNameWithHost() == name) {
             return acc;
         }

src/gui/accountstate.cpp

@@ -403,7 +403,7 @@ void AccountState::checkConnectivity(bool blockJobs)
                 _tlsDialog->setAttribute(Qt::WA_DeleteOnClose);
                 QSet<QSslCertificate> certs;
                 certs.reserve(filteredErrors.size());
-                for (const auto &error : qAsConst(filteredErrors)) {
+                for (const auto &error : std::as_const(filteredErrors)) {
                     certs << error.certificate();
                 }
                 connect(_tlsDialog, &TlsErrorDialog::accepted, _tlsDialog, [certs, blockJobs, this]() {

src/gui/activitywidget.cpp

@@ -87,7 +87,7 @@ ActivityWidget::ActivityWidget(QWidget *parent)
             showLabels();
         }
 
-        for (const auto widget : qAsConst(_widgetForNotifId)) {
+        for (const auto widget : std::as_const(_widgetForNotifId)) {
             if (widget->activity().accountUuid() == ast->account()->uuid()) {
                 scheduleWidgetToRemove(widget);
             }

src/gui/folderman.cpp

@@ -351,7 +351,7 @@ Folder *FolderMan::folder(const QByteArray &id)
 
 void FolderMan::scheduleAllFolders()
 {
-    for (auto *f : qAsConst(_folders)) {
+    for (auto *f : std::as_const(_folders)) {
         if (f && f->canSync()) {
             scheduler()->enqueueFolder(f);
         }
@@ -374,7 +374,7 @@ void FolderMan::slotIsConnectedChanged()
     if (accountState->isConnected()) {
         qCInfo(lcFolderMan) << "Account" << accountName << "connected, scheduling its folders";
 
-        for (auto *f : qAsConst(_folders)) {
+        for (auto *f : std::as_const(_folders)) {
             if (f
                 && f->canSync()
                 && f->accountState() == accountState) {
@@ -385,7 +385,7 @@ void FolderMan::slotIsConnectedChanged()
         qCInfo(lcFolderMan) << "Account" << accountName << "disconnected or paused, "
                                                            "terminating or descheduling sync folders";
 
-        for (auto *f : qAsConst(_folders)) {
+        for (auto *f : std::as_const(_folders)) {
             if (f
                 && f->isSyncRunning()
                 && f->accountState() == accountState) {
@@ -415,7 +415,7 @@ void FolderMan::slotRemoveFoldersForAccount(const AccountStatePtr &accountState)
     QList<Folder *> foldersToRemove;
     // reserve a magic number
     foldersToRemove.reserve(16);
-    for (auto *folder : qAsConst(_folders)) {
+    for (auto *folder : std::as_const(_folders)) {
         if (folder->accountState() == accountState) {
             foldersToRemove.append(folder);
         }
@@ -432,7 +432,7 @@ void FolderMan::slotServerVersionChanged(Account *account)
         qCWarning(lcFolderMan) << "The server version is unsupported:" << account->capabilities().status().versionString()
                                << "pausing all folders on the account";
 
-        for (auto &f : qAsConst(_folders)) {
+        for (auto &f : std::as_const(_folders)) {
             if (f->accountState()->account().data() == account) {
                 f->setSyncPaused(true);
             }
@@ -546,7 +546,7 @@ Folder *FolderMan::folderForPath(const QString &path, QString *relativePath)
 {
     QString absolutePath = QDir::cleanPath(path) + QLatin1Char('/');
 
-    for (auto *folder : qAsConst(_folders)) {
+    for (auto *folder : std::as_const(_folders)) {
         const QString folderPath = folder->cleanPath() + QLatin1Char('/');
 
         if (absolutePath.startsWith(folderPath, (Utility::isWindows() || Utility::isMac()) ? Qt::CaseInsensitive : Qt::CaseSensitive)) {
@@ -572,7 +572,7 @@ QStringList FolderMan::findFileInLocalFolders(const QString &relPath, const Acco
     if (!serverPath.startsWith(QLatin1Char('/')))
         serverPath.prepend(QLatin1Char('/'));
 
-    for (auto *folder : qAsConst(_folders)) {
+    for (auto *folder : std::as_const(_folders)) {
         if (acc != nullptr && folder->accountState()->account() != acc) {
             continue;
         }
@@ -638,7 +638,7 @@ QString FolderMan::getBackupName(QString fullPathName) const
 
 void FolderMan::setDirtyProxy()
 {
-    for (auto *f : qAsConst(_folders)) {
+    for (auto *f : std::as_const(_folders)) {
         if (f) {
             if (f->accountState() && f->accountState()->account()
                 && f->accountState()->account()->accessManager()) {
@@ -652,7 +652,7 @@ void FolderMan::setDirtyProxy()
 
 void FolderMan::setDirtyNetworkLimits()
 {
-    for (auto *f : qAsConst(_folders)) {
+    for (auto *f : std::as_const(_folders)) {
         // set only in busy folders. Otherwise they read the config anyway.
         if (f && f->isSyncRunning()) {
             f->setDirtyNetworkLimits();
@@ -879,7 +879,7 @@ void FolderMan::setIgnoreHiddenFiles(bool ignore)
 {
     // Note that the setting will revert to 'true' if all folders
     // are deleted...
-    for (auto *folder : qAsConst(_folders)) {
+    for (auto *folder : std::as_const(_folders)) {
         folder->setIgnoreHiddenFiles(ignore);
         folder->saveToSettings();
     }
@@ -917,7 +917,7 @@ bool FolderMan::isSpaceSynced(GraphApi::Space *space) const
 
 void FolderMan::slotReloadSyncOptions()
 {
-    for (auto *f : qAsConst(_folders)) {
+    for (auto *f : std::as_const(_folders)) {
         if (f) {
             f->reloadSyncOptions();
         }

src/gui/folderwatcher_linux.cpp

@@ -102,7 +102,7 @@ void FolderWatcherPrivate::slotAddFolderRecursive(const QString &path)
                                              << path << "'";
     }
 
-    for (const auto &subfolder : qAsConst(allSubfolders)) {
+    for (const auto &subfolder : std::as_const(allSubfolders)) {
         QDir folder(subfolder);
         if (folder.exists() && !_pathToWatch.contains(folder.absolutePath())) {
             ++subdirCount;

src/gui/folderwizard/folderwizardremotepath.cpp

@@ -221,7 +221,7 @@ void FolderWizardRemotePath::slotUpdateDirectories(const QStringList &list)
     }
     QStringList sortedList = list;
     Utility::sortFilenames(sortedList);
-    for (auto path : qAsConst(sortedList)) {
+    for (auto path : std::as_const(sortedList)) {
         path.remove(webdavFolder);
         QStringList paths = path.split(QLatin1Char('/'));
         if (paths.last().isEmpty())
@@ -323,7 +323,7 @@ bool FolderWizardRemotePath::isComplete() const
 
     bool ok = true;
 
-    for (auto *f : qAsConst(FolderMan::instance()->folders())) {
+    for (auto *f : std::as_const(FolderMan::instance()->folders())) {
         if (f->accountState()->account() != folderWizardPrivate()->accountState()->account()) {
             continue;
         }

src/gui/lockwatcher.cpp

@@ -66,7 +66,7 @@ void LockWatcher::checkFiles()
             unlocked.insert(p);
         }
     }
-    for (const auto &removed : qAsConst(unlocked)) {
+    for (const auto &removed : std::as_const(unlocked)) {
         _watchedPaths.erase(removed);
     }
 }

src/gui/main.cpp

@@ -296,7 +296,7 @@ QString setupTranslations(QApplication *app)
         return lang;
     };
 
-    for (QString lang : qAsConst(uiLanguages)) {
+    for (QString lang : std::as_const(uiLanguages)) {
         lang = substLang(lang);
         const QString trFile = Translations::translationsFilePrefix() + lang;
         if (QTranslator *translator = new QTranslator(app); translator->load(trFile, trPath) || lang.startsWith(QLatin1String("en"))) {

src/gui/models/activitylistmodel.cpp

@@ -236,7 +236,7 @@ void ActivityListModel::startFetchJob(AccountStatePtr ast)
 void ActivityListModel::combineActivityLists()
 {
     ActivityList resultList;
-    for (const ActivityList &list : qAsConst(_activityLists)) {
+    for (const ActivityList &list : std::as_const(_activityLists)) {
         resultList.append(list);
     }
     setActivityList(std::move(resultList));

src/gui/notificationwidget.cpp

@@ -119,7 +119,7 @@ void NotificationWidget::slotNotificationRequestFinished(bool success)
 
     if (!success) {
         qCWarning(lcNotifications) << "Notification Request to Server failed, leave button visible.";
-        for (auto *button : qAsConst(_buttons)) {
+        for (auto *button : std::as_const(_buttons)) {
             button->setEnabled(true);
         }
         //: The second parameter is a time, such as 'failed at 09:58pm'

src/gui/owncloudgui.cpp

@@ -279,14 +279,14 @@ void ownCloudGui::slotComputeOverallSyncStatus()
 #ifdef Q_OS_WIN
         // Windows has a 128-char tray tooltip length limit.
         QStringList accountNames;
-        for (const auto &a : qAsConst(problemAccounts)) {
+        for (const auto &a : std::as_const(problemAccounts)) {
             accountNames.append(a->account()->displayNameWithHost());
         }
         _tray->setToolTip(tr("Disconnected from %1").arg(accountNames.join(QLatin1String(", "))));
 #else
         QStringList messages;
         messages.append(tr("Disconnected from accounts:"));
-        for (const auto &a : qAsConst(problemAccounts)) {
+        for (const auto &a : std::as_const(problemAccounts)) {
             QString message = tr("Account %1").arg(a->account()->displayNameWithHost());
             if (!a->connectionErrors().empty()) {
                 message += QLatin1String("\n") + a->connectionErrors().join(QLatin1String("\n"));
@@ -585,7 +585,7 @@ void ownCloudGui::updateContextMenu()
     slotRebuildRecentMenus();
 
     // We must call deleteLater because we might be called from the press in one of the actions.
-    for (auto *menu : qAsConst(_accountMenus)) {
+    for (auto *menu : std::as_const(_accountMenus)) {
         menu->deleteLater();
     }
     _accountMenus.clear();
@@ -742,7 +742,7 @@ void ownCloudGui::slotRebuildRecentMenus()
 {
     _recentActionsMenu->clear();
     if (!_recentItemsActions.isEmpty()) {
-        for (auto *a : qAsConst(_recentItemsActions)) {
+        for (auto *a : std::as_const(_recentItemsActions)) {
             _recentActionsMenu->addAction(a);
         }
         _recentActionsMenu->addSeparator();

src/gui/selectivesyncwidget.cpp

@@ -177,7 +177,7 @@ void SelectiveSyncWidget::recursiveInsert(QTreeWidgetItem *parent, QStringList p
             item = new SelectiveSyncTreeViewItem(parent);
             if (parent->checkState(0) == Qt::Checked || parent->checkState(0) == Qt::PartiallyChecked) {
                 item->setCheckState(0, Qt::Checked);
-                for (const auto &str : qAsConst(_oldBlackList)) {
+                for (const auto &str : std::as_const(_oldBlackList)) {
                     if (str == path || str == QLatin1Char('/')) {
                         item->setCheckState(0, Qt::Unchecked);
                         break;
@@ -225,7 +225,7 @@ void SelectiveSyncWidget::slotUpdateDirectories(QStringList list)
 
     QStringList relativeList;
     relativeList.reserve(list.size());
-    for (const QString &path : qAsConst(list)) {
+    for (const QString &path : std::as_const(list)) {
         Q_ASSERT(path.startsWith(rootPath));
         const QString relativePath = path.mid(rootPath.size());
         if (!relativePath.isEmpty()) {
@@ -237,7 +237,7 @@ void SelectiveSyncWidget::slotUpdateDirectories(QStringList list)
     // list of top-level folders as soon as possible.
     if (_oldBlackList.size() == 1 && _oldBlackList.contains(QLatin1String("/"))) {
         _oldBlackList.clear();
-        for (const QString &path : qAsConst(relativeList)) {
+        for (const QString &path : std::as_const(relativeList)) {
             _oldBlackList.insert(path);
         }
     }
@@ -270,7 +270,7 @@ void SelectiveSyncWidget::slotUpdateDirectories(QStringList list)
     const bool showChildIndicator = relativeList.size() > 1 || list.contains(rootPath);
 
     Utility::sortFilenames(relativeList);
-    for (const QString &path : qAsConst(relativeList)) {
+    for (const QString &path : std::as_const(relativeList)) {
         const auto size = job ? job->sizes().value(Utility::ensureTrailingSlash(Utility::concatUrlPathItems({rootPath, path}))) : 0;
         const QStringList paths = path.split(QLatin1Char('/'), Qt::SkipEmptyParts);
         if (paths.isEmpty()) {

src/gui/sharee.cpp

@@ -127,9 +127,9 @@ void ShareeModel::fetch(const QString &search, const ShareeSet &blacklist)
 
                     // Filter sharees that we have already shared with
                     QVector<QSharedPointer<Sharee>> filteredSharees;
-                    for (const auto &sharee : qAsConst(newSharees)) {
+                    for (const auto &sharee : std::as_const(newSharees)) {
                         bool found = false;
-                        for (const auto &blacklistSharee : qAsConst(_shareeBlacklist)) {
+                        for (const auto &blacklistSharee : std::as_const(_shareeBlacklist)) {
                             if (sharee->type() == blacklistSharee->type() && sharee->shareWith() == blacklistSharee->shareWith()) {
                                 found = true;
                                 break;
@@ -194,7 +194,7 @@ void ShareeModel::setNewSharees(const QVector<QSharedPointer<Sharee>> &newSharee
 
     QModelIndexList newPersistant;
     newPersistant.reserve(persistent.size());
-    for (const auto &sharee : qAsConst(oldPersistantSharee)) {
+    for (const auto &sharee : std::as_const(oldPersistantSharee)) {
         FindShareeHelper helper = { sharee };
         auto it = std::find_if(_sharees.constBegin(), _sharees.constEnd(), helper);
         if (it == _sharees.constEnd()) {

src/gui/socketapi/socketapi.cpp

@@ -215,7 +215,7 @@ void SocketApi::slotNewConnection()
 
     auto listener = QSharedPointer<SocketListener>::create(socket);
     _listeners.insert(socket, listener);
-    for (const auto &a : qAsConst(_registeredAccounts)) {
+    for (const auto &a : std::as_const(_registeredAccounts)) {
         if (a->hasDefaultSyncRoot()) {
             broadcastMessage(buildRegisterPathMessage(Utility::stripTrailingSlash(a->defaultSyncRoot())));
         }
@@ -406,7 +406,7 @@ void SocketApi::slotUpdateFolderView(Folder *f)
 
 void SocketApi::broadcastMessage(const QString &msg, bool doWait)
 {
-    for (const auto &listener : qAsConst(_listeners)) {
+    for (const auto &listener : std::as_const(_listeners)) {
         listener->sendMessage(msg, doWait);
     }
 }
@@ -457,7 +457,7 @@ void SocketApi::broadcastStatusPushMessage(const QString &systemPath, SyncFileSt
     QString msg = buildMessage(QStringLiteral("STATUS"), systemPath, fileStatus.toSocketAPIString());
     Q_ASSERT(!systemPath.endsWith(QLatin1Char('/')));
     auto directoryHash = qHash(systemPath.left(systemPath.lastIndexOf(QLatin1Char('/'))));
-    for (const auto &listener : qAsConst(_listeners)) {
+    for (const auto &listener : std::as_const(_listeners)) {
         listener->sendMessageIfDirectoryMonitored(msg, directoryHash);
     }
 }

src/libsync/bandwidthmanager.cpp

@@ -221,7 +221,7 @@ void BandwidthManager::relativeUploadDelayTimerExpired()
     _relativeLimitCurrentMeasuredDevice->setChoked(false);
 
     // choke all other UploadDevices
-    for (auto *ud : qAsConst(_relativeUploadDeviceList)) {
+    for (auto *ud : std::as_const(_relativeUploadDeviceList)) {
         if (ud != _relativeLimitCurrentMeasuredDevice) {
             ud->setBandwidthLimited(true);
             ud->setChoked(true);
@@ -382,7 +382,7 @@ void BandwidthManager::absoluteLimitTimerExpired()
     if (usingAbsoluteUploadLimit() && !_absoluteUploadDeviceList.empty()) {
         qint64 quotaPerDevice = _currentUploadLimit / _absoluteUploadDeviceList.size();
         qCDebug(lcBandwidthManager) << quotaPerDevice << _absoluteUploadDeviceList.size() << _currentUploadLimit;
-        for (auto *device : qAsConst(_absoluteUploadDeviceList)) {
+        for (auto *device : std::as_const(_absoluteUploadDeviceList)) {
             device->giveBandwidthQuota(quotaPerDevice);
             qCDebug(lcBandwidthManager) << "Gave " << quotaPerDevice / 1024.0 << " kB to" << device;
         }

src/libsync/discovery.cpp

@@ -1361,7 +1361,7 @@ int ProcessDirectoryJob::processSubJobs(int nbJobs)
     }
 
     int started = 0;
-    for (auto *rj : qAsConst(_runningJobs)) {
+    for (auto *rj : std::as_const(_runningJobs)) {
         started += rj->processSubJobs(nbJobs - started);
         if (started >= nbJobs)
             return started;

src/libsync/networkjobs.cpp

@@ -267,7 +267,7 @@ void PropfindJob::start()
                                     "<d:propfind xmlns:d=\"DAV:\">"
                                     "<d:prop>");
 
-        for (const QByteArray &prop : qAsConst(_properties)) {
+        for (const QByteArray &prop : std::as_const(_properties)) {
             const int colIdx = prop.lastIndexOf(':');
             if (colIdx >= 0) {
                 stream << QByteArrayLiteral("<") << prop.mid(colIdx + 1) << QByteArrayLiteral(" xmlns=\"") << prop.left(colIdx) << QByteArrayLiteral("\"/>");

src/libsync/owncloudpropagator.cpp

@@ -442,7 +442,7 @@ void OwncloudPropagator::start(SyncFileItemSet &&items)
     // See the `else` statment in the second step.
     QString maybeConflictDirectory;
 
-    for (const auto &item : qAsConst(items)) {
+    for (const auto &item : std::as_const(items)) {
         // First check if this is an item in a directory which is going to be removed.
         if (currentRemoveDirectoryJob && FileSystem::isChildPathOf(item->_file, currentRemoveDirectoryJob->path())) {
             // Check the sync instruction for the item:
@@ -508,7 +508,7 @@ void OwncloudPropagator::start(SyncFileItemSet &&items)
                 // checkForPermissions() has already run and used the permissions
                 // of the file we're about to delete to decide whether uploading
                 // to the new dir is ok...
-                for (const auto &item2 : qAsConst(items)) {
+                for (const auto &item2 : std::as_const(items)) {
                     if (item2 != item && FileSystem::isChildPathOf(item2->destination(), item->destination())) {
                         item2->setInstruction(CSYNC_INSTRUCTION_NONE);
                         _anotherSyncNeeded = true;