Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the store page on Seamus's fork of the condition markers extension #86

Conversation

SeamusFinlayson
Copy link
Contributor

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234
Copy link
Collaborator

Hi @SeamusFinlayson,

Thanks for taking on the maintenance of this one!

A couple of minor edits needed, please:

  1. Could you replace the Discord invite link in your store.md with the 'official' one from our blog, YT channel etc: https://discord.gg/u5RYMkV98s
  2. We're going to de-list Keegan's extension and add your fixed version once it has passed the usual verification, but hopefully it will be quicker than usual! If this means that you need to edit your entry in extensions.json (ie. submitting a new version rather than a swap-out substitute) then please do so!

Do you already have copies of the jpg files in https://raw.githubusercontent.com/kgbergman/conditionmarkers/main/docs/ just in case you will need to host them in future?

@SeamusFinlayson
Copy link
Contributor Author

All the images and svgs are contained within the repo so that should be fine. I'll change the link and open a new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants