Added Sheet From Beyond

[alvarocavalcanti]

Make sure that your submission has the following:

• A link to the raw github markdown file with a YAML front matter definition containing:
  • The title of your extension
  • A description of your extension
  • The author
  • A hero image
  • An icon
  • Tags (these will help with your extension's discoverability)
  • A link to your extensions manifest

Please, go through these steps before you submit a PR.

• You have done your changes in a separate branch.

• You have a descriptive commit message with a short title (first line).

• You have only one commit (if not, squash them into one commit).

• Your pull request MUST target the main branch on this repository.

• Your pull request puts your extensions details as the last entry in the extensions.json file

[nthouliss]

The tag sheet is not supported. These are our supported tag with the exception of built-by-owlbear in your case.

https://github.com/owlbear-rodeo/extensions/blob/main/tags.json

[alvarocavalcanti]

The tag sheet is not supported. These are our supported tag with the exception of built-by-owlbear in your case.

https://github.com/owlbear-rodeo/extensions/blob/main/tags.json

Fixed!

[Several-Record7234]

Validation script and image URLs check out fine. Extension functionality and API usage not checked.

[Several-Record7234]

(As far as I can tell, all 13 of the task prerequisites for a PR have now been met, but @alvarocavalcanti hasn't yet edited his initial comment to reflect that.)

[alvarocavalcanti]

(As far as I can tell, all 13 of the task prerequisites for a PR have now been met, but @alvarocavalcanti hasn't yet edited his initial comment to reflect that.)

All boxes have been ticked now, and the conflicts addressed. Thanks!

[nthouliss]

Thanks for your patience @alvarocavalcanti just a few things.

1. If I hit cancel when adding a URL to the adding sheet alert message it throws an error message to the UI. I don't think this is needed when choosing to cancel.
2. I'd probably specifically mention DnDBeyond not working in Popover mode (or just throw a message in the iframe if someone tries to open a dndbeyond sheet in the popover). You can't log in since they use third party auth like Apple and Google and the iframe just fails. You mention that in this scenario it offers to open in a new tab but I didn't have this experience.
3. There's an issue with loading your icon at this url: https://sheet-from-beyond.vercel.app/img/sheet-icon.svg

[nthouliss]

(As far as I can tell, all 13 of the task prerequisites for a PR have now been met, but @alvarocavalcanti hasn't yet edited his initial comment to reflect that.)

All boxes have been ticked now, and the conflicts addressed. Thanks!

I'm happy with this and I'm ready to give it a merge but your commits need to be squashed to one commit. If you're not familiar with squashing commits I'd recommend using GitHub Desktop to do so and then doing a force push to your branch.

https://docs.github.com/en/desktop/managing-commits/squashing-commits-in-github-desktop

[alvarocavalcanti]

Thanks for your patience @alvarocavalcanti just a few things.

1. If I hit cancel when adding a URL to the adding sheet alert message it throws an error message to the UI. I don't think this is needed when choosing to cancel.

2. I'd probably specifically mention DnDBeyond not working in Popover mode (or just throw a message in the iframe if someone tries to open a dndbeyond sheet in the popover). You can't log in since they use third party auth like Apple and Google and the iframe just fails. You mention that in this scenario it offers to open in a new tab but I didn't have this experience.

3. There's an issue with loading your icon at this url: https://sheet-from-beyond.vercel.app/img/sheet-icon.svg

@nthouliss

1. I've removed the error message, now the code will just exit without adding anything to the sheet
2. I've tweaked the text, and I tested it with DDB, if you mark the sheet as public you don't need to login, just accept the cookies and it will work just fine in the popover
3. The URL has been updated

[alvarocavalcanti]

@nthouliss The commit history looks too messy to squash. I'm going to create a new PR and close this one.