Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (scatter) left-align no data section #4349

Merged
merged 1 commit into from
Dec 20, 2024
Merged

🐛 (scatter) left-align no data section #4349

merged 1 commit into from
Dec 20, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 20, 2024 •
edited
Loading

For scatters, the No Data section should be left-aligned.

@sophiamersmann Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@owidbot
Copy link
Contributor

owidbot commented Dec 20, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-scatter-no-data

SVG tester:

Number of differences (default views): 2 (a6830e) ❌
Number of differences (all views): 8 (c22fe4) ❌

Edited: 2024-12-20 16:25:02 UTC
Execution time: 1.28 seconds

@sophiamersmann sophiamersmann marked this pull request as ready for review December 20, 2024 16:27
@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Dec 20, 2024
@sophiamersmann sophiamersmann merged commit c3a1fb3 into master Dec 20, 2024
23 of 25 checks passed
@sophiamersmann sophiamersmann deleted the scatter-no-data branch December 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiamersmann sophiamersmann

Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiamersmann @owidbot