Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide floating donate button on the donation page #4345

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Dec 20, 2024

The user is already on the page we are linking to and it's easy to mistake it for the form submit button.

@owidbot
Copy link
Contributor

owidbot commented Dec 20, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-fix-confusing-floating-donat

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-20 10:52:13 UTC
Execution time: 1.32 seconds

Copy link
Member

@mlbrgl mlbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me if the bottom nav donate button competes with the form submit 👍

site/SiteTools.tsx Outdated Show resolved Hide resolved
@rakyi rakyi force-pushed the fix-confusing-floating-donate branch from d691096 to f9a9fae Compare December 20, 2024 14:03
@rakyi rakyi merged commit 286627f into master Dec 20, 2024
13 of 15 checks passed
@rakyi rakyi deleted the fix-confusing-floating-donate branch December 20, 2024 14:05
danyx23 pushed a commit that referenced this pull request Jan 9, 2025
The user is already on the page we are linking to and it's easy to mistake it for the form submit button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants