Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement feedback from QA #4297

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Implement feedback from QA #4297

merged 3 commits into from
Dec 19, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Dec 12, 2024

No description provided.

This was referenced Dec 12, 2024
Merged
Merged
Merged
@rakyi Graphite App
Copy link
Contributor Author

rakyi commented Dec 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rakyi rakyi mentioned this pull request Dec 13, 2024
Merged
@owidbot
Copy link
Contributor

owidbot commented Dec 13, 2024 •
edited
Loading

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-about-pages-qa

SVG tester:

Number of differences (default views): 2 (2c0d60) ❌
Number of differences (all views): 1 (7b610b) ❌

Edited: 2024-12-19 16:22:59 UTC
Execution time: 1.31 seconds

@rakyi rakyi force-pushed the about-pages-qa branch 2 times, most recently from 54da746 to 966fc3d Compare December 17, 2024 08:29
@rakyi rakyi force-pushed the about-pages-qa branch 4 times, most recently from e2a89a8 to 387f660 Compare December 17, 2024 17:57
@rakyi rakyi requested a review from ikesau December 17, 2024 18:04
@rakyi rakyi marked this pull request as ready for review December 17, 2024 18:04
@rakyi rakyi force-pushed the about-pages-qa branch 3 times, most recently from 84e67eb to 04ccc9e Compare December 17, 2024 19:12
ikesau
ikesau requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

just a few tiny things that we should deal with before merging, I think 🙂

db/model/Gdoc/exampleEnrichedBlocks.ts Outdated Show resolved Hide resolved
db/model/Gdoc/rawToEnriched.ts Show resolved Hide resolved
site/gdocs/components/Donors.tsx
import { useDonors } from "../utils.js"

export default function Donors({ className }: { className?: string }) {
const donors = useDonors()
if (!donors) return null

const donorsByLetter = groupBy(donors, (donor) => donor[0])
const donorsByLetter = groupBy(donors, (donor) =>
removeDiacritics(donor[0].toUpperCase())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this the first time around and though "oh that's cool, I guess we're embracing unicode multiculturalism" 😅

Guess someone else realized it was a bit silly 👍

Looks like it's not handling Ø though

image

And maybe we should just have a single "Other" heading at the bottom, because otherwise we'll get a new heading for each non-latin script name at the bottom.

Copy link
Contributor Author

@rakyi rakyi Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Marwa and I think this is fine (for now). The new code groups Í and I together, because they differ in diacritic and are ortherwise the same characters, but O with the slash is a different character than normal O. Same as e.g. Q.

site/owid.scss Outdated Show resolved Hide resolved
site/gdocs/components/centered-article.scss Show resolved Hide resolved
@rakyi rakyi requested a review from ikesau December 19, 2024 13:51
@rakyi rakyi force-pushed the about-pages-qa branch 3 times, most recently from b17e3d1 to 6100a7b Compare December 19, 2024 16:09
@rakyi Graphite App
Copy link
Contributor Author

rakyi commented Dec 19, 2024 •
edited
Loading

Merge activity

  • Dec 19, 11:41 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 11:46 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 19, 11:47 AM EST: A user merged this pull request with Graphite.

@rakyi rakyi changed the base branch from about-nav to graphite-base/4297 December 19, 2024 16:41
@rakyi rakyi changed the base branch from graphite-base/4297 to master December 19, 2024 16:43
rakyi added 3 commits December 19, 2024 16:45
@rakyi
Implement feedback from QA
43775c5
@rakyi
Fix type of EnrichedBlockCode
e886940
@rakyi
Fix alignment of deep link icon
582de9c 
Setting manual margins is fragile. Remove them to fix bad alignment in
about pages, since the icon is vertically aligned already.

It looks good to me as is, but if we want to change the alignment, we
should change the SVG instead.
@rakyi rakyi merged commit 897c586 into master Dec 19, 2024
13 of 15 checks passed
@rakyi rakyi deleted the about-pages-qa branch December 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesau ikesau ikesau approved these changes

Assignees

@rakyi rakyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakyi @owidbot @ikesau