Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gdocs): narrative charts component #4295

Merged
merged 27 commits into from
Jan 14, 2025
Merged

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Dec 12, 2024

Okay, this is now finally ready for review 🎉
This PR gets us pretty much all the way there to launch, sans some nice-to-have features.

Related project: #4128

A few notes:

Things still missing

Some things are missing, but afaict all of these are nice-to-haves, really.
See #4128 for a comprehensive list, but a few I'll also list here:

  • ✅ Would be nice if the name input dialog would be a nicer component, and would not fail with a weird error if there's a duplicate
  • Make it easy to hide all controls, in a one-click action in the admin

@owidbot
Copy link
Contributor

owidbot commented Dec 12, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-narrative-views-gdocs

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-10 11:18:36 UTC
Execution time: 1.28 seconds

@marcelgerber marcelgerber force-pushed the narrative-views-gdocs branch 7 times, most recently from 62e4ec6 to 10da0a2 Compare December 19, 2024 21:50
@marcelgerber marcelgerber changed the title feat(gdocs): narrative views component feat(gdocs): narrative charts component Dec 19, 2024
@marcelgerber marcelgerber requested a review from danyx23 December 19, 2024 22:05
@marcelgerber marcelgerber marked this pull request as ready for review December 19, 2024 22:05
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! No notes on the code :)

Feature wise I think the two things that would be nice to still do is an admin button to hide all controls and a way to see the name, ideally instead of the slug. I think these two features are high enough value to wait for those before shipping, otherwise this is ready!

Copy link

github-actions bot commented Jan 7, 2025

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Jan 7, 2025
@larsyencken larsyencken removed the stale label Jan 8, 2025
@marcelgerber marcelgerber force-pushed the narrative-views-gdocs branch 2 times, most recently from 077f5d0 to b943f29 Compare January 9, 2025 11:40
@marcelgerber marcelgerber force-pushed the narrative-views-gdocs branch from 0f23a20 to 6287939 Compare January 10, 2025 11:06
@marcelgerber marcelgerber merged commit 558d3ad into master Jan 14, 2025
16 of 19 checks passed
@marcelgerber marcelgerber deleted the narrative-views-gdocs branch January 14, 2025 07:08
@marcelgerber marcelgerber mentioned this pull request Jan 14, 2025
29 tasks
Copy link

sentry-io bot commented Jan 14, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Fetch failed: 403 Forbidden by proxy <anonymous>(packages/@ourworldindata/utils/src/... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants