About pages #4291
Closed
About pages #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 2 (e38baf) ❌ Edited: 2024-12-19 16:20:39 UTC |
danyx23
reviewed
Dec 12, 2024
packages/@ourworldindata/types/src/gdocTypes/ArchieMlComponents.ts
Outdated
Show resolved
Hide resolved
rakyi
force-pushed
the
about-pages
branch
3 times, most recently
from
587f6d9 to
05cbf27
Compare
rakyi
force-pushed
the
about-pages
branch
4 times, most recently
from
84e67eb to
04ccc9e
Compare
Setting manual margins is fragile. Remove them to fix bad alignment in about pages, since the icon is vertically aligned already. It looks good to me as is, but if we want to change the alignment, we should change the SVG instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.