✨ Add button to see which posts images are used in #4286
Merged
+188
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
commented
Dec 11, 2024
| @@ -3138,17 +3138,6 @@ getRouteNonIdempotentWithRWTransaction( | |||
| postRouteWithRWTransaction(apiRouter, "/images", async (req, res, trx) => { | |||
| const { filename, type, content } = validateImagePayload(req.body) | |||
|
|
|||
| const preexisting = await trx<DbEnrichedImage>("images") | |||
There was a problem hiding this comment.
This is a change that Daniel suggested - it's annoying to be told to rename an image, only to find out that the hash collides after.
So now we check for the hash collision first.
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-11 23:16:07 UTC |
rakyi
approved these changes
Dec 12, 2024
nah, but the currently most-reused image is 5, which looked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more feature for the images admin! Last one! I promise! 😅
image.usage.button.demo.mp4