Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 migrate images of unpublished gdoc posts that were missing #4281

Merged
merged 1 commit into from
Dec 11, 2024
+6 −2
Merged

🔨 migrate images of unpublished gdoc posts that were missing #4281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions devTools/cloudflareImagesSync/cloudflareImagesSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,11 @@ async function fetchImagesFromDatabase(trx: db.KnexReadWriteTransaction) {
console.log("Fetching images from the database...")
return await trx("images")
.select("images.*")
.whereIn("images.id", trx("posts_gdocs_x_images").distinct("imageId"))
// We used to filter to only images that are referenced in posts_gdocs_x_images but
// that was strangely only filled for published posts. On 2024-12-10/11 when we migrated
// images from gdrive to cloudflare, there were 2400 images, of which around 800
// were excluded by this. Most of these seemed sensible to have so I opted to just
// transfer all images that we have in the images table.
.whereNotNull("images.id")
.whereNotNull("images.filename")
.orderBy("filename", "asc")
Expand Down Expand Up @@ -421,7 +425,7 @@ async function uploadImagesToCloudflareImages(
async function main() {
if (!CLOUDFLARE_IMAGES_ACCOUNT_ID || !CLOUDFLARE_IMAGES_API_KEY) {
console.error(
`Cloudflare Images credentials not set.
`Cloudflare Images credentials not set.
You need to set "CLOUDFLARE_IMAGES_ACCOUNT_ID" and "CLOUDFLARE_IMAGES_API_KEY" in your .env`
)
return
Expand Down
Loading