Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix default gdoc thumbnails not rendering in gdocs #4270

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Dec 9, 2024

Fixes the following whoopsie

image

image

@ikesau ikesau requested a review from danyx23 December 9, 2024 14:54
@ikesau ikesau self-assigned this Dec 9, 2024
@@ -65,6 +66,12 @@ import { ChartHit } from "./ChartHit.js"
const siteAnalytics = new SiteAnalytics()

function PagesHit({ hit }: { hit: IPageHit }) {
// a temporary fix for articles that have been indexed without the directory
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed as part of #4214

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ikesau ikesau merged commit 6fb21e8 into master Dec 9, 2024
20 of 22 checks passed
@ikesau ikesau deleted the fix-default-thumbnails-in-search branch December 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants