✨ show average daily pageviews in charts list and references tab #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-06 18:05:23 UTC |
marcelgerber
approved these changes
Dec 9, 2024
adminSiteClient/ChartIndexPage.tsx
Outdated
Comment on lines
59
to
65
| return [...filtered].sort((a, b) => { | ||
| const aValue = a.pageviewsPerDay || 0 | ||
| const bValue = b.pageviewsPerDay || 0 | ||
| return sortConfig.direction === "desc" | ||
| ? bValue - aValue | ||
| : aValue - bValue | ||
| }) |
There was a problem hiding this comment.
Probably better to use the existing sortNumeric from utils here.
Just take caution because it sorts in-place, but your current solution is, too :)
Comment on lines
217
to
220
| ? Math.round( | ||
| this.pageviews?.views_365d / 36.5 | ||
| ) / 10 | ||
| : undefined |
There was a problem hiding this comment.
This is a bit arcane - I would prefer you use lodash's round(num, 1) instead.
There was a problem hiding this comment.
Ah this is much better, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a small request by authors - surfacing pageviews more prominently is useful prioritizing work on charts.
This PR shows the average daily pageviews in the chart index page and allows users to sort by these pageviews.
An index on analytics_pageviews is added so that joins can be more performant