✨ Filter for only active columns in grapher data download #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-02 16:28:20 UTC |
marcelgerber
reviewed
Dec 3, 2024
| @@ -606,11 +606,30 @@ export class OwidTable extends CoreTable<OwidRow, OwidColumnDef> { | |||
| } | |||
|
|
|||
| // Give our users a clean CSV of each Grapher. Assumes an Owid Table with entityName. | |||
| toPrettyCsv(useShortNames: boolean = false): string { | |||
| toPrettyCsv( | |||
| // | |||
Comment on lines
614
to
627
| const activeColumnsDiff: Set<string> = activeColumnSlugs | ||
| ? differenceOfSets([ | ||
| new Set(this.columnSlugs), | ||
| new Set(activeColumnSlugs), | ||
| ]) | ||
| : new Set() | ||
| const columnSlugsToRemove = differenceOfSets([ | ||
| activeColumnsDiff, | ||
| new Set([ | ||
| OwidTableSlugs.year, | ||
| OwidTableSlugs.day, | ||
| this.entityNameSlug, | ||
| ]), | ||
| ]) |
There was a problem hiding this comment.
I think this all would be a bit cleaner and easier to follow if it was using this.select() instead. The two diffs after one another are hard to reason about, after all.
I.e. something like:
if (activeColumnSlugs?.length) {
this.select([year, day, entityName, ...activeColumnSlugs])
} else {
this.dropColumns(...)
}There was a problem hiding this comment.
Ah very nice! I looked a bit to see if we had the inverse of drop and was looking for pick or keep but didn't think of select. Much nicer, thanks!
marcelgerber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter data downloads in grapher to only the actively used columns. Not doing this was a problem for csv based explorers that can have a huge number of columns.