Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Take user to variable edit page instead of dataset when clicking on a pencil #4231

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

Marigold
Copy link
Contributor

@Marigold Marigold commented Nov 28, 2024

Clicking on a pencil in the sources tab will now take you to variable edit page (if the variable id exists). (Joe's request, check this slack thread)

image

@owidbot
Copy link
Contributor

owidbot commented Nov 28, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-source-edit-variable

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-28 19:43:42 UTC
Execution time: 1.23 seconds

Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :) I pushed one quick cosmetic commit (I hope I didn't mess it up). Should be good to go!

@Marigold Marigold merged commit d1c6b0d into master Nov 29, 2024
21 checks passed
@Marigold Marigold deleted the source-edit-variable branch November 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants