Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minimum browser versions we support #4215

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Nov 26, 2024

I think it's time :)

This is dropping support for Safari 12 in particular, and beginning our browser support at Safari 13.1.
This makes us support browsers going back to early 2020, roughly 4.5 years.

I've hand-checked the features that Vite enables with this change, and it's mainly:

  • No longer transpiling ES6 template literals but keeping them in their ES6 syntax
  • Including the nullish coalescing operator (??) as-is in the output JS and not transpiling it
  • In CSS, it's dropping some vendor prefixes, e.g. -webkit-sticky, -webkit-text-decoration-color.

I've tested this in Safari 12 and Chrome 78, both of which are properly falling back to our no-JS solution (because of syntax errors related to ??). Safari 13.1 is working fine.

@owidbot
Copy link
Contributor

owidbot commented Nov 26, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-update-min-browser

SVG tester:

Number of differences (default views): 1366 (1971c7) ❌
Number of differences (all views): 0 ✅

Edited: 2024-11-26 10:34:38 UTC
Execution time: 1.24 seconds

@marcelgerber marcelgerber marked this pull request as ready for review November 26, 2024 11:44
@marcelgerber marcelgerber requested a review from rakyi November 26, 2024 11:44
Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Nice drop in bundle size!

@marcelgerber marcelgerber changed the title chore: update minimum browsers we support chore: update minimum browser versions we support Nov 26, 2024
@marcelgerber marcelgerber merged commit 4998e3c into master Nov 26, 2024
11 of 14 checks passed
@marcelgerber marcelgerber deleted the update-min-browser branch November 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants